Skip to content

Commit a3881ac

Browse files
authored
1 parent 4106db5 commit a3881ac

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

tests/unit/admin/views/test_projects.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -749,6 +749,7 @@ class TestAddRole:
749749
def test_add_role(self, db_request):
750750
role_name = "Maintainer"
751751
project = ProjectFactory.create(name="foo")
752+
UserFactory.create(username="admin")
752753
user = UserFactory.create(username="bar")
753754

754755
db_request.route_path = pretend.call_recorder(lambda *a, **kw: "/the-redirect/")
@@ -843,6 +844,7 @@ def test_delete_role(self, db_request):
843844
project = ProjectFactory.create(name="foo")
844845
user = UserFactory.create(username="bar")
845846
role = RoleFactory.create(project=project, user=user)
847+
UserFactory.create(username="admin")
846848

847849
db_request.route_path = pretend.call_recorder(lambda *a, **kw: "/the-redirect/")
848850
db_request.session = pretend.stub(

warehouse/admin/views/projects.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -609,7 +609,7 @@ def add_role(project, request):
609609
tag=EventTag.Project.RoleAdd,
610610
request=request,
611611
additional={
612-
"submitted_by": user_service.get_admin_user(),
612+
"submitted_by": user_service.get_admin_user().username,
613613
"role_name": role_name,
614614
"target_user": user.username,
615615
},
@@ -618,7 +618,7 @@ def add_role(project, request):
618618
tag=EventTag.Account.RoleAdd,
619619
request=request,
620620
additional={
621-
"submitted_by": user_service.get_admin_user(),
621+
"submitted_by": user_service.get_admin_user().username,
622622
"project_name": project.name,
623623
"role_name": role_name,
624624
},
@@ -678,7 +678,7 @@ def delete_role(project, request):
678678
tag=EventTag.Project.RoleRemove,
679679
request=request,
680680
additional={
681-
"submitted_by": user_service.get_admin_user(),
681+
"submitted_by": user_service.get_admin_user().username,
682682
"role_name": role.role_name,
683683
"target_user": role.user.username,
684684
},

0 commit comments

Comments
 (0)