Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise Docker CI #1343

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Revise Docker CI #1343

wants to merge 4 commits into from

Conversation

davide-f
Copy link
Member

@davide-f davide-f commented Feb 6, 2025 •
edited
Loading

Closes #1303

Changes proposed in this Pull Request

This PR aims to revise the docker workflow and settings to set it on this branch.

It would be greatly appreciated a review by @GbotemiB and @drifter089

Testing log is here: https://github.com/davide-f/pypsa-earth/actions/runs/13125191058 the only change I did after moving here are chaning the path and release-note.
To be sure, we could test in a branch in upstream to ensure it works

Checklist

  • I consent to the release of this PR's code under the AGPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and doc/requirements.txt.
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@GbotemiB
Copy link
Collaborator

@davide-f, Thank you for looking into this and taking care of it. Looks good to me.
But, I dont know how to test this in a branch. But will be great to test it.

From my end, we are good to go.

@davide-f
Copy link
Member Author

@davide-f, Thank you for looking into this and taking care of it. Looks good to me. But, I dont know how to test this in a branch. But will be great to test it.

From my end, we are good to go.

Many thanks!
@drifter089 mentioned that he will review the PR, waiting for his feedback too.

To test it, you could copy the branch and change the path in .devcontainer/devcontainer.json to match your github.
Then you can trigger the CI manually from the Actions tab of your repo.

That should be it

@drifter089
Copy link
Contributor

image
@davide-f
if we add registry token and registry user it should automatically pick up the creds

drifter089
drifter089 reviewed Feb 14, 2025
View reviewed changes
.github/workflows/devcontainer.yml
cacheFrom: ghcr.io/${{ github.repository }}-dev-env
imageName: ghcr.io/${{ github.repository }}-dev-env
push: always
# This changes all uppercase characters to lowercase.
Copy link
Contributor

@drifter089 drifter089 Feb 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we can use the devcontainer action as it will use cache to rebuild the image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drifter089 drifter089 drifter089 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor fix to allow workflow dev containers
3 participants
@davide-f @GbotemiB @drifter089