Allow .R.

Author: tobiasraabe

src/pytask_r/collect.py

@@ -93,10 +93,13 @@ def pytask_collect_task(
             ),
         )
 
-        if not (isinstance(script_node, PathNode) and script_node.path.suffix == ".r"):
+        if not (
+            isinstance(script_node, PathNode)
+            and script_node.path.suffix in (".r", ".R")
+        ):
             msg = (
                 "The 'script' keyword of the @pytask.mark.r decorator must point "
-                f"to an R file with the .r extension, but it is {script_node}."
+                f"to an R file with the .r or .R extension, but it is {script_node}."
             )
             raise ValueError(msg)
 

tests/test_execute.py

@@ -45,9 +45,7 @@ def test_run_r_script(  # noqa: PLR0913
     @pytask.mark.r(script="script.r", serializer="{serializer}", suffix="{suffix}")
     @pytask.mark.depends_on({depends_on})
     @pytask.mark.produces("out.txt")
-    def task_run_r_script():
-        pass
-
+    def task_run_r_script(): ...
     """
     tmp_path.joinpath("task_dummy.py").write_text(textwrap.dedent(task_source))
     tmp_path.joinpath("in_1.txt").touch()
@@ -77,14 +75,12 @@ def test_run_r_script_w_task_decorator(
     runner, tmp_path, parse_config_code, serializer, suffix
 ):
     task_source = f"""
-    import pytask
-
-    @pytask.mark.task
-    @pytask.mark.r(script="script.r", serializer="{serializer}", suffix="{suffix}")
-    @pytask.mark.produces("out.txt")
-    def run_r_script():
-        pass
+    from pytask import task, mark
 
+    @task
+    @mark.r(script="script.r", serializer="{serializer}", suffix="{suffix}")
+    @mark.produces("out.txt")
+    def run_r_script(): ...
     """
     tmp_path.joinpath("task_dummy.py").write_text(textwrap.dedent(task_source))
 
@@ -113,8 +109,7 @@ def test_raise_error_if_rscript_is_not_found(
 
     @pytask.mark.r(script="script.r", serializer="{serializer}", suffix="{suffix}")
     @pytask.mark.produces("out.txt")
-    def task_run_r_script():
-        pass
+    def task_run_r_script(): ...
     """
     tmp_path.joinpath("task_dummy.py").write_text(textwrap.dedent(task_source))
 
@@ -152,8 +147,7 @@ def test_run_r_script_w_saving_workspace(
         suffix="{suffix}"
     )
     @pytask.mark.produces("out.txt")
-    def task_run_r_script():
-        pass
+    def task_run_r_script(): ...
     """
     tmp_path.joinpath("task_dummy.py").write_text(textwrap.dedent(task_source))
 
@@ -188,8 +182,7 @@ def test_run_r_script_w_wrong_cmd_option(
         suffix="{suffix}"
     )
     @pytask.mark.produces("out.txt")
-    def task_run_r_script():
-        pass
+    def task_run_r_script(): ...
     """
     tmp_path.joinpath("task_dummy.py").write_text(textwrap.dedent(task_source))
 
@@ -216,8 +209,7 @@ def test_run_r_script_w_custom_serializer(runner, tmp_path):
 
     @pytask.mark.r(script="script.r", serializer=json.dumps, suffix=".json")
     @pytask.mark.produces("out.txt")
-    def task_run_r_script():
-        pass
+    def task_run_r_script(): ...
 
     """
     tmp_path.joinpath("task_dummy.py").write_text(textwrap.dedent(task_source))
@@ -247,8 +239,7 @@ def test_run_r_script_fails_w_multiple_markers(runner, tmp_path):
     @pytask.mark.r(script="script.r")
     @pytask.mark.r(script="script.r")
     @pytask.mark.produces("out.txt")
-    def task_run_r_script():
-        pass
+    def task_run_r_script(): ...
     """
     tmp_path.joinpath("task_dummy.py").write_text(textwrap.dedent(task_source))
     tmp_path.joinpath("script.r").touch()
@@ -257,3 +248,31 @@ def task_run_r_script():
 
     assert result.exit_code == ExitCode.COLLECTION_FAILED
     assert "has multiple @pytask.mark.r marks" in result.output
+
+
+@needs_rscript
+@pytest.mark.end_to_end()
+def test_run_r_script_with_capital_extension(runner, tmp_path):
+    task_source = """
+    import pytask
+
+    @pytask.mark.r(script="script.R")
+    @pytask.mark.produces("out.txt")
+    def task_run_r_script(): ...
+    """
+    tmp_path.joinpath("task_dummy.py").write_text(textwrap.dedent(task_source))
+
+    r_script = """
+    library(jsonlite)
+    args <- commandArgs(trailingOnly=TRUE)
+    config <- read_json(args[length(args)])
+    file_descriptor <- file(config$produces)
+    writeLines(c("So, so you think you can tell heaven from hell?"), file_descriptor)
+    close(file_descriptor)
+    """
+    tmp_path.joinpath("script.R").write_text(textwrap.dedent(r_script))
+
+    result = runner.invoke(cli, [tmp_path.as_posix()])
+
+    assert result.exit_code == ExitCode.OK
+    assert tmp_path.joinpath("out.txt").exists()