New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_get_distribution_version is broken with pytest 7.2 and tox 4 #43

Closed

frenzymadness opened this issue Nov 30, 2022 · 1 comment · Fixed by #47

Labels

bug help wanted

frenzymadness commented Nov 30, 2022

This assert

apipkg/test_apipkg.py

Line 835 in 70a9a03

assert apipkg.distribution_version("py") is not None

counts that py will always be installed but pytest 7.2 and tox 4 no longer depend on py so it might not be available which makes this test to fail.

mgorny commented Dec 22, 2022

Making assertion on setuptools also doesn't sound future-proof for a PEP517 world where build requirements are only installed in a temporary venv.

RonnyPfannschmidt added bug help wanted labels

RonnyPfannschmidt mentioned this issue

remove py reference from tests #47

Merged

RonnyPfannschmidt closed this as completed in #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment