Skip to content

Commit b19904e

Browse files
RonnyPfannschmidtCursor AIclaude
committed
fix(downstream): fix tox CI detection, devpi deselect, drop conda env hack
- tox: also override GITHUB_ACTIONS=false (is_ci() checks both CI and GITHUB_ACTIONS env vars) - devpi: switch --deselect to --ignore for test_upload.py (deselect path didn't match pytest node IDs) - conda: remove CONDA_CHANNELS override — it fixes NoChannels tests but breaks channel-configuration tests; remaining failures are upstream conda CI infrastructure issues Co-authored-by: Cursor AI <ai@cursor.sh> Co-authored-by: Anthropic Claude Opus 4 <claude@anthropic.com>
1 parent 314bbe0 commit b19904e

3 files changed

Lines changed: 6 additions & 8 deletions

File tree

downstream/recipes/conda.toml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,3 @@ argv = [
1818
"-c",
1919
"set +eu; source dev/start; set -eu; pytest -m 'not integration and not installed'",
2020
]
21-
# Many conda tests create temporary envs that need channels to resolve
22-
# packages; setting CONDA_CHANNELS provides a sensible default on CI.
23-
env = { CONDA_CHANNELS = "defaults,conda-forge" }

downstream/recipes/devpi.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ argv = ["pytest", "common"]
1818
argv = ["pytest", "server"]
1919

2020
[[test]]
21-
# Deselect test_upload: upstream conftest bug compares code=[200,200,200]
21+
# Ignore test_upload: upstream conftest bug compares code=[200,200,200]
2222
# against integers, causing TypeError on every upload-with-docs test.
23-
argv = ["pytest", "client", "--deselect=client/testing/test_upload.py"]
23+
argv = ["pytest", "client", "--ignore=client/testing/test_upload.py"]
2424

2525
[[test]]
2626
argv = ["pytest", "web"]

downstream/recipes/tox.toml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ groups = ["test"]
1414

1515
[[test]]
1616
argv = ["pytest"]
17-
# tox detects CI=true and enables list_dependencies by default, inserting
18-
# extra "freeze" steps that its own test expectations don't account for.
19-
env = { CI = "false" }
17+
# tox's is_ci() checks CI, GITHUB_ACTIONS, and many other env vars;
18+
# all must be unset/false so list_dependencies defaults to False and
19+
# test expectations (no freeze steps, spinner enabled, etc.) hold.
20+
env = { CI = "false", GITHUB_ACTIONS = "false" }

0 commit comments

Comments
 (0)