-
Notifications
You must be signed in to change notification settings - Fork 159
CI: add job that that uses pytest-dev version #1132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
OK, so all the failures are going away if/when I have the following ignore for the deprecation, so I suspect the problem itself is very much related to #924 and related issues.
|
Thanks for the issue report! A first step towards this might be adding a new tox environment that uses |
I would go further than |
This would increase the likelihood of instability because it applies to everything in the deptree. Instead, doing |
That's a good idea. Use the |
One option could be only running it on cron (and perhaps merge queues) and not PRs to avoid confusing the contributors. |
@seifertm by the way, as long as |
Yes, that's certainly a way, and works really well when also coupled with a labelling system that can trigger these non-default jobs (I suppose this much scaffolding is an overkill for a plugin though). Here is another example tox where we don't even have a dev env for multiple dependencies, just doing it for pytest: https://github.com/scientific-python/pytest-doctestplus/blob/main/tox.ini#L34 |
As far as I see there is no CI job that tests using the dev version of the dependencies. My experience while maintaining a couple of pytest plugins is that having a job dor dev-dependencies is a very valuable smoke test to see when things start go wrong due to upstream changes.
(And I'm opening this issue as I discovered our own test suite at pytest-doctestplus is throwing a lot of failures when pytest-asyncio is installed and we use the dev version of pytest. I don't see any problems when pytest-asyncio is not present, so my best assumptions without diving into the rabbit hole, is that at least part of the failures are not doctestplus related)
The text was updated successfully, but these errors were encountered: