Skip to content

helping the maintenance bus factor #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RonnyPfannschmidt opened this issue Dec 21, 2021 · 19 comments
Closed

helping the maintenance bus factor #232

RonnyPfannschmidt opened this issue Dec 21, 2021 · 19 comments

Comments

@RonnyPfannschmidt
Copy link
Member

It seems that maintenance has come to a halt,
in this issue i want to prepare communicating current factors and/or enable a call for help

the goal being documenting the current state,
so people have a idea what to expect while the shortage of committable volunteer time means less happens
as well as organizing additional volunteers that can help the process.

CC @pytest-dev/pytest-asyncio-admin

@Tinche
Copy link
Member

Tinche commented Dec 21, 2021

It's true, since my time is spread between a lot of other projects at this point I essentially only make sure this plugin works on new Pythons.

Note that I actively use the plugin on a daily basis, so despite the amount of issues I know the plugin actually works. But I would welcome some qualified help, of course.

@RonnyPfannschmidt
Copy link
Member Author

@Tinche its great to know that you are indeed a regular user and the minimum is secured

as for qualified help - would it be ok if i did a call for help using the pytestorg twitter account nd may i mention you and/or would you like to do the call for help so we can add reach to it?

@Tinche
Copy link
Member

Tinche commented Dec 21, 2021

Ugh I think if we do a call for help on Twitter we will get a ton of unqualified help, which will be even more work. Can we get some pytest folks in first? So maybe through the mailing list?

@RonnyPfannschmidt
Copy link
Member Author

yes we can, i agree that the qualification filtering can be quite a pain

do you want to try to get something out to the pytest-dev ml or would you like for me to draft something up between the days

@Tinche
Copy link
Member

Tinche commented Dec 21, 2021

Would appreciate assistance ;)

@RonnyPfannschmidt RonnyPfannschmidt self-assigned this Dec 21, 2021
@RonnyPfannschmidt
Copy link
Member Author

i'll spend time on this between christmas and the new year
i wont mind anyone beating me to it tho ;P

@RonnyPfannschmidt
Copy link
Member Author

initial email to pytest-dev is out

@asvetlov
Copy link
Contributor

asvetlov commented Jan 3, 2022

Well, I can help with the maintenance.
I use pytest-asyncio at my daily job and maintain asyncio itself as a part of CPython.

@RonnyPfannschmidt
Copy link
Member Author

@Tinche in addition to @asvetlov , @seifertm also reached out on the ml

i haven't yet found the time to look deeply into them, but at first glance it looks like both of them bring good experience

do you already have some rough idea of them so we can cut it short, else i'll take a deeper look mid week (my initial impression is good)

@Tinche
Copy link
Member

Tinche commented Jan 3, 2022

I would be very glad to have @asvetlov and @seifertm as fellow maintainers.

As a first step: do you folks have any PRs yourselves that I should review ASAP? If yes I will do so.

As a second step: I will defer to your judgement on what PRs to merge in and what issues to close/not close.

After a while when we've built up a working relationship, I'm happy giving you folks commit rights here on GitHub and co-ownership on PyPI.

@asvetlov
Copy link
Contributor

asvetlov commented Jan 4, 2022

I have no my PRs.
There is a pull request from @seifertm #192 which looks good to me.

@asvetlov
Copy link
Contributor

asvetlov commented Jan 6, 2022

Reviewed a bunch of existing PRs, skipped pull requests that are not bad for me but maybe should be fixed differently.

I would say that missing write access prevents me from trying to resolve merge conflicts on GitHub.

The next stage should be issue triaging.

@Tinche
Copy link
Member

Tinche commented Jan 6, 2022

@asvetlov thank you very much with your help!

@nicoddemus can you add @asvetlov to the pytest-asyncio-admin group?

@nicoddemus
Copy link
Member

@nicoddemus can you add @asvetlov to the pytest-asyncio-admin group?

I can, but I made you maintainer of the team, please check if you can add @asvetlov yourself.

@Tinche
Copy link
Member

Tinche commented Jan 6, 2022

@nicoddemus It says he's 'not a member of this organization'. Do we need to add him to pytest first?

@nicoddemus
Copy link
Member

Hmm seems like it, sent an invitation:

image

@Tinche
Copy link
Member

Tinche commented Jan 7, 2022

@nicoddemus can you do the same for @seifertm please?

@RonnyPfannschmidt
Copy link
Member Author

i did it

@asvetlov
Copy link
Contributor

asvetlov commented Jan 8, 2022

We can close it I guess.

@asvetlov asvetlov closed this as completed Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants