Refactor a bit the internals to be a bit less boilerplatey and have more clarity. The config/nodeid were never meant to be optional for this internal class - the intention there was to signal that they can be None values.

Author: ionelmc

src/pytest_cov/engine.py

@@ -1,5 +1,6 @@
 """Coverage controllers for use by pytest-cov and nose-cov."""
 
+import argparse
 import contextlib
 import copy
 import functools
@@ -69,14 +70,14 @@ class CovController:
 
     cov: coverage.Coverage | None
 
-    def __init__(self, cov_source, cov_report, cov_config, cov_append, cov_branch, cov_precision, config=None, nodeid=None):
+    def __init__(self, options: argparse.Namespace, config: None | object, nodeid: None | str):
         """Get some common config used by multiple derived classes."""
-        self.cov_source = cov_source
-        self.cov_report = cov_report
-        self.cov_config = cov_config
-        self.cov_append = cov_append
-        self.cov_branch = cov_branch
-        self.cov_precision = cov_precision
+        self.cov_source = options.cov_source
+        self.cov_report = options.cov_report
+        self.cov_config = options.cov_config
+        self.cov_append = options.cov_append
+        self.cov_branch = options.cov_branch
+        self.cov_precision = options.cov_precision
         self.config = config
         self.nodeid = nodeid
 

src/pytest_cov/plugin.py

@@ -202,7 +202,7 @@ class CovPlugin:
     distributed worker.
     """
 
-    def __init__(self, options, pluginmanager, start=True, no_cov_should_warn=False):
+    def __init__(self, options: argparse.Namespace, pluginmanager, start=True, no_cov_should_warn=False):
         """Creates a coverage pytest plugin.
 
         We read the rc file that coverage uses to get the data file
@@ -244,24 +244,15 @@ def __init__(self, options, pluginmanager, start=True, no_cov_should_warn=False)
 
         # worker is started in pytest hook
 
-    def start(self, controller_cls: 'CovController', config=None, nodeid=None):
+    def start(self, controller_cls: type['CovController'], config=None, nodeid=None):
         if config is None:
             # fake config option for engine
             class Config:
                 option = self.options
 
             config = Config()
 
-        self.cov_controller = controller_cls(
-            self.options.cov_source,
-            self.options.cov_report,
-            self.options.cov_config,
-            self.options.cov_append,
-            self.options.cov_branch,
-            self.options.cov_precision,
-            config,
-            nodeid,
-        )
+        self.cov_controller = controller_cls(self.options, config, nodeid)
         self.cov_controller.start()
         self._started = True
         self._start_path = Path.cwd()