Skip to content

Commit 38b8a6c

Browse files
authored
Fix for #806 (if results table order changed, hide/show details hover over broken) (#807)
* Fix for #806
1 parent 4b714aa commit 38b8a6c

File tree

2 files changed

+20
-2
lines changed

2 files changed

+20
-2
lines changed

src/pytest_html/scripts/dom.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,10 @@ const dom = {
5757
}
5858

5959
if (collapsed) {
60-
resultBody.querySelector('.collapsible > td')?.classList.add('collapsed')
60+
resultBody.querySelector('.collapsible > .col-result')?.classList.add('collapsed')
6161
resultBody.querySelector('.extras-row').classList.add('hidden')
6262
} else {
63-
resultBody.querySelector('.collapsible > td')?.classList.remove('collapsed')
63+
resultBody.querySelector('.collapsible > .col-result')?.classList.remove('collapsed')
6464
}
6565

6666
const media = []

testing/test_integration.py

+18
Original file line numberDiff line numberDiff line change
@@ -870,6 +870,24 @@ def test_CCC():
870870
for row, expected in zip(result, order):
871871
assert_that(row.string).contains(expected)
872872

873+
def test_collapsed_class_when_results_table_order_changed(self, pytester):
874+
pytester.makeconftest(
875+
"""
876+
def pytest_html_results_table_header(cells):
877+
cells.append(cells.pop(0))
878+
879+
def pytest_html_results_table_row(report, cells):
880+
cells.append(cells.pop(0))
881+
"""
882+
)
883+
pytester.makepyfile("def test_pass(): pass")
884+
page = run(pytester)
885+
assert_results(page, passed=1)
886+
887+
assert_that(
888+
get_text(page, "#results-table td[class='col-result collapsed']")
889+
).is_true()
890+
873891

874892
class TestLogCapturing:
875893
LOG_LINE_REGEX = r"\s+this is {}"

0 commit comments

Comments
 (0)