Fix automatic download of pdf content type. closes #14

Author: bubenkoff

CHANGES.rst

@@ -1,6 +1,12 @@
 Changelog
 =========
 
+1.2.5
+-----
+
+- Fix automatic download of pdf content type (bubenkoff)
+
+
 1.2.4
 -----
 

README.rst

@@ -99,6 +99,10 @@ Fixtures
     Firefox profile preferences, a dictionary which is passed to selenium
     webdriver's profile_preferences
 
+* splinter_firefox_profile_directory
+    Firefox profile directory to use as template for firefox profile created by selenium.
+    By default, it's an empty directly inside pytest_splinter/profiles/firefox
+
 * splinter_driver_kwargs
     Webdriver keyword arguments, a dictionary which is passed to selenium
     webdriver's constructor (after applying firefox preferences)

pytest_splinter/__init__.py

@@ -1 +1 @@
-__version__ = '1.2.4'
+__version__ = '1.2.5'

pytest_splinter/plugin.py

@@ -154,6 +154,12 @@ def splinter_firefox_profile_preferences():
     }
 
 
+@pytest.fixture(scope='session')
+def splinter_firefox_profile_directory():
+    """Firefox profile directory."""
+    return os.path.join(os.path.dirname(__file__), 'profiles', 'firefox')
+
+
 @pytest.fixture(scope='session')
 def splinter_driver_kwargs():
     """Webdriver kwargs."""
@@ -219,6 +225,7 @@ def browser_instance_getter(
     splinter_driver_kwargs,
     splinter_file_download_dir,
     splinter_firefox_profile_preferences,
+    splinter_firefox_profile_directory,
     splinter_make_screenshot_on_failure,
     splinter_remote_url,
     splinter_screenshot_dir,
@@ -243,7 +250,9 @@ def browser_instance_getter(
             'browser.download.dir': splinter_file_download_dir,
             'browser.helperApps.neverAsk.saveToDisk': splinter_download_file_types,
             'browser.helperApps.alwaysAsk.force': False,
+            'pdfjs.disabled': True,  # disable internal ff pdf viewer to allow auto pdf download
         }, **splinter_firefox_profile_preferences)
+        kwargs['profile'] = splinter_firefox_profile_directory
     elif splinter_webdriver == 'remote':
         kwargs['url'] = splinter_remote_url
     if splinter_driver_kwargs:

tests/test_plugin.py

@@ -30,15 +30,26 @@ def test_browser(browser):
     assert isinstance(browser, plugin.Browser)
 
 
-def test_download_file(httpserver, browser, splinter_file_download_dir):
+@pytest.mark.parametrize(
+    (
+        'file_extension',
+        'mime_type'
+    ),
+    (
+        ['txt', 'text/plain'],
+        ['pdf', 'application/pdf'],
+    )
+)
+def test_download_file(httpserver, browser, splinter_file_download_dir, file_extension, mime_type):
     """Test file downloading and accessing it afterwise."""
+    file_name = 'some.{0}'.format(file_extension)
     httpserver.serve_content(
         'Some text file', code=200, headers={
-            'Content-Disposition': 'attachment; filename=some.txt',
-            'Content-Type': 'text/plain'})
+            'Content-Disposition': 'attachment; filename={0}'.format(file_name),
+            'Content-Type': mime_type})
     browser.visit(httpserver.url)
     time.sleep(0.5)
-    assert open(os.path.join(splinter_file_download_dir, 'some.txt')).read() == 'Some text file'
+    assert open(os.path.join(splinter_file_download_dir, file_name)).read() == 'Some text file'
 
 
 @pytest.mark.parametrize('cookie_value', ['value1', 'value2'])