Code review

Author: nicoddemus

src/_pytest/config/__init__.py

@@ -1607,8 +1607,10 @@ def getini(self, name: str):
 
     # Meant for easy monkeypatching by legacypath plugin.
     # Can be inlined back (with no cover removed) once legacypath is gone.
-    def _getini_unknown_type(self, name: str, type: str, value: str | list[str]):
-        msg = f"unknown configuration type: {type}"
+    def _getini_unknown_type(self, name: str, type: str, value: object):
+        msg = (
+            f"Option {name} has unknown configuration type {type} with value {value!r}"
+        )
         raise ValueError(msg, value)  # pragma: no cover
 
     def _getini(self, name: str):
@@ -1671,16 +1673,12 @@ def _getini(self, name: str):
         elif type == "float":
             if not isinstance(value, (str, float)):
                 raise TypeError(
-                    f"Expected str or flot for option {name} of type float, but got: {value!r}"
+                    f"Expected str or float for option {name} of type float, but got: {value!r}"
                 ) from None
             return float(value)
         elif type is None:
             return value
         else:
-            if not isinstance(value, (str, Sequence)):
-                raise TypeError(
-                    f"Expected str or sequence for option {name} of type str/list, but got: {value!r}"
-                ) from None
             return self._getini_unknown_type(name, type, value)
 
     def _getconftest_pathlist(

src/_pytest/config/findpaths.py

@@ -21,7 +21,9 @@
 
     from typing_extensions import TypeAlias
 
-    ConfigDict: TypeAlias = dict[str, Union[str, int, float, list[str]]]
+    # Even though TOML supports richer data types, all values are converted to str/list[str] during
+    # parsing to maintain compatibility with the rest of the configuration system.
+    ConfigDict: TypeAlias = dict[str, Union[str, list[str]]]
 
 
 def _parse_ini_config(path: Path) -> iniconfig.IniConfig:

testing/test_config.py

@@ -866,6 +866,23 @@ def pytest_addoption(parser):
         config = pytester.parseconfig()
         assert config.getini("ini_param") == int_val
 
+    def test_addini_int_invalid(self, pytester: Pytester) -> None:
+        pytester.makeconftest(
+            """
+            def pytest_addoption(parser):
+                parser.addini("ini_param", "", type="int", default=2)
+        """
+        )
+        pytester.makepyprojecttoml(
+            """
+            [tool.pytest.ini_options]
+            ini_param=["foo"]
+            """
+        )
+        config = pytester.parseconfig()
+        with pytest.raises(TypeError, match="Expected str or int for option ini_param"):
+            _ = config.getini("ini_param")
+
     @pytest.mark.parametrize("str_val, float_val", [("10.5", 10.5), ("no-ini", 2.2)])
     def test_addini_float(
         self, pytester: Pytester, str_val: str, float_val: bool
@@ -886,6 +903,25 @@ def pytest_addoption(parser):
         config = pytester.parseconfig()
         assert config.getini("ini_param") == float_val
 
+    def test_addini_float_invalid(self, pytester: Pytester) -> None:
+        pytester.makeconftest(
+            """
+            def pytest_addoption(parser):
+                parser.addini("ini_param", "", type="float", default=2.2)
+        """
+        )
+        pytester.makepyprojecttoml(
+            """
+            [tool.pytest.ini_options]
+            ini_param=["foo"]
+            """
+        )
+        config = pytester.parseconfig()
+        with pytest.raises(
+            TypeError, match="Expected str or float for option ini_param"
+        ):
+            _ = config.getini("ini_param")
+
     def test_addinivalue_line_existing(self, pytester: Pytester) -> None:
         pytester.makeconftest(
             """