Switch fully to GH Actions

Author: nhooyr

.github/workflows/ci.yaml

@@ -3,13 +3,60 @@ name: ci
 on: [push, pull_request]
 
 jobs:
-  arm64-release:
-    name: linux-arm64-release
-    runs-on: [Linux, ARM64]
+  test:
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v1
-      - run: ./ci/steps/linux-release.sh
-      - uses: actions/upload-artifact@v2
+      - name: Run ./ci/steps/test.sh
+        uses: ./ci/container
+        with:
+          args: ./ci/steps/test.sh
+
+  linux-amd64:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v1
+      - name: Run ./ci/steps/release.sh
+        uses: ./ci/container
+        with:
+          args: ./ci/steps/release.sh
+      - name: Upload release artifacts
+        uses: actions/upload-artifact@v2
+        with:
+          name: release-github
+          path: ./release-github/*
+      - name: Upload npm package artifact
+        uses: actions/upload-artifact@v2
+        with:
+          name: npm-package
+          path: ./release
+
+  linux-arm64:
+    runs-on: ubuntu-arm64-latest
+    steps:
+      - uses: actions/checkout@v1
+      - name: Run ./ci/steps/release.sh
+        uses: ./ci/container
+        with:
+          args: ./ci/steps/release.sh
+      - name: Upload release artifacts
+        uses: actions/upload-artifact@v2
+        with:
+          name: release-github
+          path: ./release-github/*
+
+  macos:
+    runs-on: macos-latest
+    steps:
+      - uses: actions/checkout@v1
+      - run: brew unlink node@12
+      - run: brew install node
+      - run: ./ci/steps/release.sh
+        env:
+          # Otherwise we get a rate limited when fetching the ripgrep binary.
+          GITHUB_TOKEN: ${{ secrets.github_token }}
+      - name: Upload release artifacts
+        uses: actions/upload-artifact@v2
         with:
           name: release-github
           path: ./release-github/*

.travis.yml

@@ -68,15 +68,11 @@ This directory contains the container for CI.
 
 ## steps
 
-This directory contains a few scripts used in CI. Just helps avoid clobbering .travis.yml.
+This directory contains a few scripts used in CI.
+Just helps avoid clobbering .travis.yml.
 
 - [./steps/test.sh](./steps/test.sh)
   - Runs `yarn ci` after ensuring VS Code is patched
-- [./steps/static-release.sh](./steps/static-release.sh)
+- [./steps/release.sh](./steps/release.sh)
   - Runs the full static build process for CI
-- [./steps/linux-release.sh](./steps/linux-release.sh)
-  - Runs the full static build process for CI
-  - Packages the release into a .deb and .rpm
-  - Builds and pushes a docker release
-- [./steps/publish-npm.sh](./steps/publish-npm.sh)
-  - Authenticates yarn and publishes the built package from `./release`
+  - Packages the release into a .deb and .rpm for linux

ci/README.md

@@ -1,30 +1,41 @@
-FROM centos:7
-
-RUN yum update -y && yum install -y \
-    devtoolset-6 \
-    gcc-c++ \
-    xz \
-    ccache \
-    git \
-    wget \
-    openssl \
-    libxkbfile-devel \
-    libsecret-devel \
-    libx11-devel \
-    gettext
-
-RUN yum install -y epel-release && \
-    yum install -y ShellCheck jq golang
+FROM debian
 
-RUN go get github.com/goreleaser/nfpm/cmd/nfpm
-ENV PATH=$PATH:/root/go/bin
+RUN apt-get update
+
+# Needed for debian repositories added below.
+RUN apt-get install -y curl gnupg
+
+# Installs node.
+RUN curl -sL https://deb.nodesource.com/setup_14.x | bash - && \
+    apt-get install -y nodejs
+
+# Installs yarn.
+RUN curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add - && \
+    echo "deb https://dl.yarnpkg.com/debian/ stable main" | tee /etc/apt/sources.list.d/yarn.list && \
+    apt-get update && apt-get install -y yarn
 
-RUN mkdir /usr/share/node && cd /usr/share/node \
-    && curl "https://nodejs.org/dist/v12.16.3/node-v12.16.3-linux-$(uname -m | sed 's/86_//; s/aarch/arm/').tar.xz" | tar xJ --strip-components=1 --
-ENV PATH "$PATH:/usr/share/node/bin"
-RUN npm install -g yarn@1.22.4
+# Installs VS Code build deps.
+RUN apt-get install -y build-essential \
+                   libsecret-1-dev \
+                   libx11-dev \
+                   libxkbfile-dev
 
-RUN curl -L "https://github.com/mvdan/sh/releases/download/v3.0.1/shfmt_v3.0.1_linux_$(uname -m | sed 's/x86_/amd/; s/aarch64/arm/')" > /usr/local/bin/shfmt \
-    && chmod +x /usr/local/bin/shfmt
+# Installs envsubst.
+RUN apt-get install -y gettext-base
 
-ENTRYPOINT ["/bin/bash", "-c"]
+# Misc build dependencies.
+RUN apt-get install -y jq git rsync
+
+# Installs shellcheck.
+RUN curl -L https://github.com/koalaman/shellcheck/releases/download/v0.7.1/shellcheck-v0.7.1.linux.$(uname -m).tar.xz | \
+    tar -xJ && \
+    mv shellcheck*/shellcheck /usr/local/bin && \
+    rm -R shellcheck*
+
+# Install Go dependencies
+RUN ARCH="$(dpkg --print-architecture)" && \
+    curl "https://dl.google.com/go/go1.14.2.linux-$ARCH.tar.gz" | tar -C /usr/local -xz
+ENV PATH=/usr/local/go/bin:/root/go/bin:$PATH
+ENV GO111MODULE=on
+RUN go get mvdan.cc/sh/v3/cmd/shfmt
+RUN go get github.com/goreleaser/nfpm/cmd/nfpm

ci/container/Dockerfile

@@ -48,6 +48,22 @@ index 7a2320d828..5768890636 100644
 +// yarnInstall('test/smoke'); // node modules required for smoketest
 +// yarnInstall('test/integration/browser'); // node modules required for integration
  yarnInstallBuildDependencies(); // node modules for watching, specific to host node version, not electron
+diff --git a/build/npm/preinstall.js b/build/npm/preinstall.js
+index cb88d37ade..6b3253af0a 100644
+--- a/build/npm/preinstall.js
++++ b/build/npm/preinstall.js
+@@ -8,8 +8,9 @@ let err = false;
+ const majorNodeVersion = parseInt(/^(\d+)\./.exec(process.versions.node)[1]);
+ 
+ if (majorNodeVersion < 10 || majorNodeVersion >= 13) {
+-	console.error('\033[1;31m*** Please use node >=10 and <=12.\033[0;0m');
+-	err = true;
++	// We are ok building above Node 12.
++	// console.error('\033[1;31m*** Please use node >=10 and <=12.\033[0;0m');
++	// err = true;
+ }
+ 
+ const cp = require('child_process');
 diff --git a/coder.js b/coder.js
 new file mode 100644
 index 0000000000..0170b47241

ci/container/exec.sh

@@ -27,11 +27,8 @@ ENV SHELL=/bin/bash
 RUN adduser --gecos '' --disabled-password coder && \
   echo "coder ALL=(ALL) NOPASSWD:ALL" >> /etc/sudoers.d/nopasswd
 
-SHELL ["/bin/bash", "-c"]
-
-COPY ci/lib.sh /tmp/lib.sh
-RUN source /tmp/lib.sh && rm /tmp/lib.sh && \
-    curl -L "https://github.com/boxboat/fixuid/releases/download/v0.4.1/fixuid-0.4.1-linux-$(arch).tar.gz" | tar -C /usr/local/bin -xzf - && \
+RUN ARCH="$(dpkg --print-architecture)" && \
+    curl -L "https://github.com/boxboat/fixuid/releases/download/v0.4.1/fixuid-0.4.1-linux-$ARCH.tar.gz" | tar -C /usr/local/bin -xzf - && \
     chown root:root /usr/local/bin/fixuid && \
     chmod 4755 /usr/local/bin/fixuid && \
     mkdir -p /etc/fixuid && \

ci/dev/vscode.patch

@@ -11,6 +11,10 @@ main() {
   STATIC=1 yarn release
   ./ci/build/test-static-release.sh
   ./ci/build/archive-static-release.sh
+
+  if [[ $OSTYPE == linux* ]]; then
+    yarn pkg
+  fi
 }
 
 main "$@"