Skip to content

Commit dc6de6a

Browse files
committed
Remove unnecessary noqa comments
1 parent 116d5ec commit dc6de6a

File tree

2 files changed

+29
-29
lines changed

2 files changed

+29
-29
lines changed

formate/dynamic_quotes.py

+6-6
Original file line numberDiff line numberDiff line change
@@ -47,15 +47,15 @@
4747
__all__ = ["dynamic_quotes"]
4848

4949

50-
class QuoteRewriter(Rewriter): # noqa: D101
50+
class QuoteRewriter(Rewriter):
5151

5252
if sys.version_info[:2] < (3, 8): # pragma: no cover (py38+)
5353

54-
def visit_Str(self, node: ast.Str) -> None: # noqa: D102
54+
def visit_Str(self, node: ast.Str) -> None:
5555
self.rewrite_quotes_for_node(node)
5656
else: # pragma: no cover (<py38)
5757

58-
def visit_Constant(self, node: ast.Constant) -> None: # noqa: D102
58+
def visit_Constant(self, node: ast.Constant) -> None:
5959
if isinstance(node.value, str):
6060
self.rewrite_quotes_for_node(node)
6161
else:
@@ -74,13 +74,13 @@ def visit_definition(self, node: Union[ast.ClassDef, ast.FunctionDef, ast.AsyncF
7474

7575
self.generic_visit(node)
7676

77-
def visit_ClassDef(self, node: ast.ClassDef) -> None: # noqa: D102
77+
def visit_ClassDef(self, node: ast.ClassDef) -> None:
7878
self.visit_definition(node)
7979

80-
def visit_FunctionDef(self, node: ast.FunctionDef) -> None: # noqa: D102
80+
def visit_FunctionDef(self, node: ast.FunctionDef) -> None:
8181
self.visit_definition(node)
8282

83-
def visit_ASyncFunctionDef(self, node: ast.AsyncFunctionDef) -> None: # noqa: D102
83+
def visit_ASyncFunctionDef(self, node: ast.AsyncFunctionDef) -> None:
8484
self.visit_definition(node)
8585

8686
def rewrite_quotes_for_node(self, node: Union[ast.Str, ast.Constant]) -> None:

formate/reformat_generics.py

+23-23
Original file line numberDiff line numberDiff line change
@@ -127,13 +127,13 @@ def __repr__(self) -> str:
127127
return f"[{self.elements:, }]"
128128

129129

130-
class Visitor(ast.NodeVisitor): # noqa: D101
130+
class Visitor(ast.NodeVisitor):
131131
in_class = False
132132

133133
def __init__(self):
134134
self.unions: typing.List[typing.Tuple[ast.Subscript, Generic, bool]] = []
135135

136-
def visit_Subscript(self, node: ast.Subscript) -> None: # noqa: D102
136+
def visit_Subscript(self, node: ast.Subscript) -> None:
137137
if isinstance(node.value, ast.Name) and node.value.id in collection_types:
138138
union = Generic(node.value.id, UnionVisitor().visit(get_slice_value(node.slice)))
139139
self.unions.append((node, union, self.in_class))
@@ -151,40 +151,40 @@ def visit_Subscript(self, node: ast.Subscript) -> None: # noqa: D102
151151

152152
self.generic_visit(node)
153153

154-
def visit(self, node: ast.AST) -> typing.List[typing.Tuple[ast.Subscript, Generic, bool]]: # noqa: D102
154+
def visit(self, node: ast.AST) -> typing.List[typing.Tuple[ast.Subscript, Generic, bool]]:
155155
super().visit(node)
156156
return self.unions
157157

158-
def visit_FunctionDef(self, node: ast.FunctionDef) -> None: # noqa: D102
158+
def visit_FunctionDef(self, node: ast.FunctionDef) -> None:
159159
return None
160160

161-
def visit_ClassDef(self, node: ast.ClassDef) -> None: # noqa: D102
161+
def visit_ClassDef(self, node: ast.ClassDef) -> None:
162162
self.unions.extend(ClassVisitor().visit(node))
163163

164-
def visit_AsyncFunctionDef(self, node: ast.AsyncFunctionDef) -> None: # noqa: D102
164+
def visit_AsyncFunctionDef(self, node: ast.AsyncFunctionDef) -> None:
165165
return None
166166

167167

168-
class ClassVisitor(Visitor): # noqa: D101
168+
class ClassVisitor(Visitor):
169169
in_class = True
170170

171-
def visit_ClassDef(self, node: ast.ClassDef) -> None: # noqa: D102
171+
def visit_ClassDef(self, node: ast.ClassDef) -> None:
172172
self.generic_visit(node)
173173

174174

175-
class UnionVisitor(ast.NodeVisitor): # noqa: D101
175+
class UnionVisitor(ast.NodeVisitor):
176176

177177
def __init__(self):
178178
super().__init__()
179179
self.structure: typing.List[typing.Union[str, Generic, List]] = []
180180

181-
def generic_visit(self, node: ast.AST) -> None: # noqa: D102
181+
def generic_visit(self, node: ast.AST) -> None:
182182
super().generic_visit(node)
183183

184-
def visit_Name(self, node: ast.Name) -> None: # noqa: D102
184+
def visit_Name(self, node: ast.Name) -> None:
185185
self.structure.append(f"{node.id}")
186186

187-
def visit_Attribute(self, node: ast.Attribute) -> None: # noqa: D102
187+
def visit_Attribute(self, node: ast.Attribute) -> None:
188188
parts: DelimitedList[str] = DelimitedList()
189189
value: typing.Union[ast.Name, ast.expr] = node.value
190190

@@ -203,45 +203,45 @@ def visit_Attribute(self, node: ast.Attribute) -> None: # noqa: D102
203203

204204
self.structure.append(f"{parts:.}.{node.attr}")
205205

206-
def visit_Subscript(self, node: ast.Subscript) -> None: # noqa: D102
206+
def visit_Subscript(self, node: ast.Subscript) -> None:
207207
union = Generic(
208208
'.'.join(astatine.get_attribute_name(node.value)),
209209
UnionVisitor().visit(get_slice_value(node.slice)),
210210
)
211211
self.structure.append(union)
212212

213-
def visit_List(self, node: ast.List) -> None: # noqa: D102
213+
def visit_List(self, node: ast.List) -> None:
214214
elements = []
215215
for child in node.elts:
216216
elements.extend(UnionVisitor().visit(child))
217217
self.structure.append(List(elements))
218218

219-
def visit_Load(self, node: ast.Load) -> None: # noqa: D102
219+
def visit_Load(self, node: ast.Load) -> None:
220220
return None
221221

222-
def visit_FunctionDef(self, node: ast.FunctionDef) -> None: # noqa: D102
222+
def visit_FunctionDef(self, node: ast.FunctionDef) -> None:
223223
return None
224224

225-
def visit_ClassDef(self, node: ast.ClassDef) -> None: # noqa: D102
225+
def visit_ClassDef(self, node: ast.ClassDef) -> None:
226226
self.generic_visit(node)
227227

228-
def visit_AsyncFunctionDef(self, node: ast.AsyncFunctionDef) -> None: # noqa: D102
228+
def visit_AsyncFunctionDef(self, node: ast.AsyncFunctionDef) -> None:
229229
return None
230230

231-
def visit_NameConstant(self, node: ast.NameConstant) -> None: # noqa: D102
231+
def visit_NameConstant(self, node: ast.NameConstant) -> None:
232232
self.structure.append(node.value)
233233

234234
if sys.version_info[:2] < (3, 8): # pragma: no cover (py38+)
235235

236-
def visit_Str(self, node: ast.Str) -> None: # noqa: D102
236+
def visit_Str(self, node: ast.Str) -> None:
237237
self.structure.append(f'"{node.s}"')
238238

239-
def visit_Ellipsis(self, node: ast.Ellipsis) -> None: # noqa: D102
239+
def visit_Ellipsis(self, node: ast.Ellipsis) -> None:
240240
self.structure.append("...")
241241

242242
else: # pragma: no cover (<py38)
243243

244-
def visit_Constant(self, node: ast.Constant) -> None: # noqa: D102
244+
def visit_Constant(self, node: ast.Constant) -> None:
245245
if isinstance(node.value, str):
246246
self.structure.append(f'"{node.value}"')
247247
elif node.value is Ellipsis:
@@ -252,7 +252,7 @@ def visit_Constant(self, node: ast.Constant) -> None: # noqa: D102
252252
print(node, node.value)
253253
self.generic_visit(node)
254254

255-
def visit(self, node: ast.AST) -> typing.List[typing.Union[str, Generic, List]]: # noqa: D102
255+
def visit(self, node: ast.AST) -> typing.List[typing.Union[str, Generic, List]]:
256256
super().visit(node)
257257
return self.structure
258258

0 commit comments

Comments
 (0)