Deployment approve/reject via python api supported?

[jbotello7381]

I was playing with deployment and gitlab python library, and notice there's no method to approve or reject a deployment? i was able to do it via REST API from my python code, but not via the python wrapper. I'm using 3.8.1 of the gitlab python library.

[JohnVillalovos]

Would be useful to have a link to the upstream GitLab API docs for what is missing. Thanks.

[jbotello7381]

Sorry, this is the endpoint
https://docs.gitlab.com/ee/ci/environments/deployment_approvals.html#approve-or-reject-a-deployment-using-the-api

[JohnVillalovos]

So it looks like it is this API:
https://docs.gitlab.com/ee/api/deployments.html#approve-or-reject-a-blocked-deployment

And it doesn't look like there is any support for that yet in:
https://github.com/python-gitlab/python-gitlab/blob/main/gitlab/v4/objects/deployments.py

Implementing it will look similar to how the "approve" method is done for a merge request.

python-gitlab/gitlab/v4/objects/merge_requests.py

Lines 263 to 290 in f67514e

	@cli.register_custom_action("ProjectMergeRequest", (), ("sha",))
	@exc.on_http_error(exc.GitlabMRApprovalError)
	def approve(self, sha: Optional[str] = None, **kwargs: Any) -> Dict[str, Any]:
	"""Approve the merge request.
	Args:
	sha: Head SHA of MR
	**kwargs: Extra options to send to the server (e.g. sudo)
	Raises:
	GitlabAuthenticationError: If authentication is not correct
	GitlabMRApprovalError: If the approval failed
	Returns:
	A dict containing the result.
	https://docs.gitlab.com/ee/api/merge_request_approvals.html#approve-merge-request
	"""
	path = f"{self.manager.path}/{self.encoded_id}/approve"
	data = {}
	if sha:
	data["sha"] = sha
	server_data = self.manager.gitlab.http_post(path, post_data=data, **kwargs)
	if TYPE_CHECKING:
	assert isinstance(server_data, dict)
	self._update_attrs(server_data)
	return server_data

[JohnVillalovos]

I opened #2253 as a RFE (Request For Enhancement)

[JohnVillalovos]

Created a PR: #2254

[jbotello7381]

I tested on my local environment with your PR and it works. Thanks for the quick PR.

[JohnVillalovos]

I tested on my local environment with your PR and it works. Thanks for the quick PR.

Thanks for the test! Glad to know it works.