Skip to content

Commit f7c4c53

Browse files
committed
convert events.UnknownFrame into a dataclass
1 parent 14ada5c commit f7c4c53

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

src/h2/connection.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1972,8 +1972,7 @@ def _receive_unknown_frame(self, frame: ExtensionFrame) -> tuple[list[Frame], li
19721972
self.config.logger.debug(
19731973
"Received unknown extension frame (ID %d)", frame.stream_id,
19741974
)
1975-
event = UnknownFrameReceived()
1976-
event.frame = frame
1975+
event = UnknownFrameReceived(frame=frame)
19771976
return [], [event]
19781977

19791978
def _local_settings_acked(self) -> dict[SettingCodes | int, ChangedSetting]:

src/h2/events.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -635,6 +635,7 @@ def __repr__(self) -> str:
635635
)
636636

637637

638+
@dataclass(**kw_only)
638639
class UnknownFrameReceived(Event):
639640
"""
640641
The UnknownFrameReceived event is fired when the remote peer sends a frame
@@ -650,9 +651,7 @@ class UnknownFrameReceived(Event):
650651
.. versionadded:: 2.7.0
651652
"""
652653

653-
def __init__(self) -> None:
654-
#: The hyperframe Frame object that encapsulates the received frame.
655-
self.frame: Frame | None = None
654+
frame: Frame
656655

657656
def __repr__(self) -> str:
658657
return "<UnknownFrameReceived>"

tests/test_events.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
import inspect
88
import sys
99

10+
import hyperframe.frame
1011
import pytest
1112
from hypothesis import given
1213
from hypothesis.strategies import integers, lists, tuples
@@ -360,7 +361,7 @@ def test_unknownframereceived_repr(self) -> None:
360361
"""
361362
UnknownFrameReceived has a useful debug representation.
362363
"""
363-
e = h2.events.UnknownFrameReceived()
364+
e = h2.events.UnknownFrameReceived(frame=hyperframe.frame.Frame(1))
364365
assert repr(e) == "<UnknownFrameReceived>"
365366

366367

0 commit comments

Comments
 (0)