Skip to content

Commit 4c797a1

Browse files
committed
feat: inherit PyMySQLReplicationVersion8TestCase in TestColumnValueNoneSources
1 parent cb37436 commit 4c797a1

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

pymysqlreplication/tests/test_basic.py

+6-2
Original file line numberDiff line numberDiff line change
@@ -1737,7 +1737,7 @@ def tearDown(self):
17371737
super(TestOptionalMetaData, self).tearDown()
17381738

17391739

1740-
class TestColumnValueNoneSources(base.PyMySQLReplicationTestCase):
1740+
class TestColumnValueNoneSources(base.PyMySQLReplicationVersion8TestCase):
17411741
def setUp(self):
17421742
super(TestColumnValueNoneSources, self).setUp()
17431743
self.stream.close()
@@ -1747,7 +1747,9 @@ def setUp(self):
17471747
only_events=(TableMapEvent,),
17481748
)
17491749
if not self.isMySQL8014AndMore():
1750-
self.skipTest("Mysql version is under 8.0.14 - pass TestOptionalMetaData")
1750+
self.skipTest(
1751+
"Mysql version is under 8.0.14 - pass TestColumnValueNoneSources"
1752+
)
17511753
self.execute("SET GLOBAL binlog_row_metadata='FULL';")
17521754

17531755
def test_get_none(self):
@@ -1788,6 +1790,8 @@ def test_get_none_invalid(self):
17881790

17891791
self.assertIsInstance(self.stream.fetchone(), RotateEvent)
17901792
self.assertIsInstance(self.stream.fetchone(), FormatDescriptionEvent)
1793+
self.assertIsInstance(self.stream.fetchone(), PreviousGtidsEvent)
1794+
self.assertIsInstance(self.stream.fetchone(), GtidEvent)
17911795
self.assertIsInstance(self.stream.fetchone(), QueryEvent)
17921796
self.assertIsInstance(self.stream.fetchone(), TableMapEvent)
17931797

0 commit comments

Comments
 (0)