Skip to content

Rule codes do not respect the Flake8 specification, making yesqa break flake8-async noqa statements #293

Closed
@PLPeeters

Description

@PLPeeters

I tried using yesqa in conjunction with flake8-async in my pre-commit hooks, but I ran into an issue where yesqa would not play nice with the flake8-async rule codes. I raised an issue there initially, but was told the flake8-async codes do not abide by the Flake8 requirements, which unfortunately turns out to be correct.

Quoting the docs:

A 3 letters entry point prefix followed by 3 numbers (i.e. ABC123) is currently the longest allowed entry point name.

Question is: what now? Changing the prefix for the codes isn't exactly a non-breaking change, but then again not respecting the requirements set out by Flake8 probably ought to be considered a bug as it might lead to errors somewhere down the line.

In a way, I'm wondering if the best solution here isn't challenging this limitation with the Flake8 maintainers as it does seem arbitrary, especially since your 5-letter prefixes seem to be working just fine. Thoughts?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions