_pickle: Fix whichmodule() (#3358)

vstinner · tiran · commit af46eb8d5f23 · 2017-09-05T14:30:16.000-07:00
_PyUnicode_FromId() can return NULL: replace Py_INCREF() with Py_XINCREF(). Fix coverity report: CID 1417269.
diff --git a/Modules/_pickle.c b/Modules/_pickle.c
@@ -1705,7 +1705,7 @@ whichmodule(PyObject *global, PyObject *dotted_path)
 
     /* If no module is found, use __main__. */
     module_name = _PyUnicode_FromId(&PyId___main__);
-    Py_INCREF(module_name);
+    Py_XINCREF(module_name);
     return module_name;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1705,7 +1705,7 @@ whichmodule(PyObject global, PyObject dotted_path)`
`1705`	`1705`
`1706`	`1706`	`/* If no module is found, use __main__. */`
`1707`	`1707`	`module_name = _PyUnicode_FromId(&PyId___main__);`
`1708`		`- Py_INCREF(module_name);`
	`1708`	`+ Py_XINCREF(module_name);`
`1709`	`1709`	`return module_name;`
`1710`	`1710`	`}`
`1711`	`1711`