Skip to content

Commit 1f10981

Browse files
authored
New semantic analyzer: enable function tests (#6611)
This changes a false positive to a false negative, which is perhaps a reasonable tradeoff for now. I filed an issue about the false negative (#6610).
1 parent 92dc144 commit 1f10981

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

mypy/test/hacks.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
'check-async-await.test',
1111
'check-expressions.test',
1212
'check-flags.test',
13-
'check-functions.test',
1413
'check-incremental.test',
1514
'check-literal.test',
1615
'check-overloading.test',

test-data/unit/check-functions.test

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1394,6 +1394,7 @@ else:
13941394
def f(x: str) -> None: pass # E: Incompatible redefinition (redefinition with type "Callable[[str], None]", original type "Callable[[int], None]")
13951395

13961396
[case testConditionalFunctionDefinitionUsingDecorator3]
1397+
# flags: --new-semantic-analyzer
13971398
from typing import Callable
13981399

13991400
def dec(f) -> Callable[[int], None]: pass
@@ -1402,11 +1403,11 @@ x = int()
14021403
if x:
14031404
def f(x: int) -> None: pass
14041405
else:
1405-
# TODO: This should be okay.
1406-
@dec # E: Name 'f' already defined on line 7
1406+
@dec
14071407
def f(): pass
14081408

14091409
[case testConditionalFunctionDefinitionUsingDecorator4]
1410+
# flags: --new-semantic-analyzer
14101411
from typing import Callable
14111412

14121413
def dec(f) -> Callable[[int], None]: pass
@@ -1415,8 +1416,8 @@ x = int()
14151416
if x:
14161417
def f(x: str) -> None: pass
14171418
else:
1418-
# TODO: We should report an incompatible redefinition.
1419-
@dec # E: Name 'f' already defined on line 7
1419+
# TODO: Complain about incompatible redefinition
1420+
@dec
14201421
def f(): pass
14211422

14221423
[case testConditionalRedefinitionOfAnUnconditionalFunctionDefinition1]

0 commit comments

Comments
 (0)