Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental does not re-process module with ignored import if the imported module appears on a new run #1910

Closed
gvanrossum opened this issue Jul 19, 2016 · 1 comment
Labels

Comments

@gvanrossum
Copy link
Member

Suppose I have a.py:

import b  # type: ignore
b.foo()

and there's no b.py or b.pyi on the path. This checks without errors, and in incremental mode does not record b as a dependency of a.

Now I create a valid b.py, and re-run mypy -i a.py (this is with a warm cache). I had expected it would mark a as stale and re-parse it, but it doesn't.

A suspicious change is 4889c0c ("Warn about unused '# type: ignore' comments (#1695)") which apparently made the effect of # type: ignore on imports much more severe, also without -i.

(This seems related to #1904 but I think it's a separate issue. Also, I think it's low priority since it only applies to ignored top-level imports, not to imports of submodules of packages.)

@ilevkivskyi
Copy link
Member

Since incremental is now on by default raise priority to high.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants