Fix BadHeaderError when a story name contains newlines

Sentry issue number: PYDOTORG-PROD-24

Author: berkerpeksag

successstories/models.py

@@ -136,8 +136,10 @@ def send_email_to_psf(sender, instance, created, **kwargs):
 
 Review URL: {admin_url}
         """
+        name_lines = instance.name.splitlines()
+        name = name_lines[0] if name_lines else instance.name
         email = EmailMessage(
-            'New success story submission: {}'.format(instance.name),
+            'New success story submission: {}'.format(name),
             body.format(
                 name=instance.name,
                 company_name=instance.company_name,

successstories/tests/test_views.py

@@ -120,3 +120,33 @@ def test_story_create(self):
         self.assertContains(response, 'Please use a unique name.')
 
         del mail.outbox[:]
+
+    def test_story_multiline_email_subject(self):
+        mail.outbox = []
+
+        url = reverse('success_story_create')
+
+        post_data = {
+            'name': 'First line\nSecond line',
+            'company_name': 'Company Three',
+            'company_url': 'http://djangopony.com/',
+            'category': self.category.pk,
+            'author': 'Kevin Arnold',
+            'author_email': '[email protected]',
+            'pull_quote': 'Liver!',
+            'content': 'Growing up is never easy.\n\nFoo bar baz.\n',
+            settings.HONEYPOT_FIELD_NAME: settings.HONEYPOT_VALUE,
+        }
+
+        response = self.client.post(url, post_data)
+        self.assertEqual(response.status_code, 302)
+        self.assertRedirects(response, url)
+
+        self.assertEqual(len(mail.outbox), 1)
+        self.assertEqual(
+            mail.outbox[0].subject,
+            'New success story submission: First line'
+        )
+        self.assertNotIn('Second line', mail.outbox[0].subject)
+
+        del mail.outbox[:]