Skip to content

Commit 822fae3

Browse files
authored
Remove Python 3.8 from CI (#13387)
1 parent f2c917f commit 822fae3

File tree

6 files changed

+8
-8
lines changed

6 files changed

+8
-8
lines changed

.github/workflows/daily.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ jobs:
3737
# As of 2024-10-18, ubuntu-latest can refer to different Ubuntu versions,
3838
# which can can cause problems with os module constants.
3939
os: ["ubuntu-24.04", "windows-latest", "macos-latest"]
40-
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
40+
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
4141
fail-fast: false
4242

4343
steps:

.github/workflows/stubtest_stdlib.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333
# As of 2024-10-18, ubuntu-latest can refer to different Ubuntu versions,
3434
# which can can cause problems with os module constants.
3535
os: ["ubuntu-24.04", "windows-latest", "macos-latest"]
36-
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
36+
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
3737
fail-fast: false
3838

3939
steps:

.github/workflows/tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ jobs:
6262
strategy:
6363
matrix:
6464
platform: ["linux", "win32", "darwin"]
65-
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
65+
python-version: ["3.9", "3.10", "3.11", "3.12"]
6666
fail-fast: false
6767
steps:
6868
- uses: actions/checkout@v4
@@ -113,7 +113,7 @@ jobs:
113113
strategy:
114114
matrix:
115115
python-platform: ["Linux", "Windows", "Darwin"]
116-
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
116+
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
117117
fail-fast: false
118118
steps:
119119
- uses: actions/checkout@v4

tests/mypy_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
print_error("Cannot import mypy. Did you install it?")
4545
sys.exit(1)
4646

47-
SUPPORTED_VERSIONS = ["3.13", "3.12", "3.11", "3.10", "3.9", "3.8"]
47+
SUPPORTED_VERSIONS = ["3.13", "3.12", "3.11", "3.10", "3.9"]
4848
SUPPORTED_PLATFORMS = ("linux", "win32", "darwin")
4949
DIRECTORIES_TO_TEST = [STDLIB_PATH, STUBS_PATH]
5050

tests/regr_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
TYPESHED = "typeshed"
4141

4242
SUPPORTED_PLATFORMS = ["linux", "darwin", "win32"]
43-
SUPPORTED_VERSIONS = ["3.13", "3.12", "3.11", "3.10", "3.9", "3.8"]
43+
SUPPORTED_VERSIONS = ["3.13", "3.12", "3.11", "3.10", "3.9"]
4444

4545

4646
def distribution_with_test_cases(distribution_name: str) -> DistributionTests:

tests/runtests.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
_FAILED = colored("Failed", "red")
2323
# We're using the oldest fully supported version because it's the most likely to produce errors
2424
# due to unsupported syntax, feature, or bug in a tool.
25-
_PYTHON_VERSION = "3.8"
25+
_PYTHON_VERSION = "3.9"
2626

2727

2828
def _parse_jsonc(json_text: str) -> str:
@@ -55,7 +55,7 @@ def main() -> None:
5555
parser.add_argument(
5656
"--python-version",
5757
default=_PYTHON_VERSION,
58-
choices=("3.8", "3.9", "3.10", "3.11", "3.12", "3.13"),
58+
choices=("3.9", "3.10", "3.11", "3.12", "3.13"),
5959
help="Target Python version for the test (default: %(default)s).",
6060
)
6161
parser.add_argument("path", help="Path of the stub to test in format <folder>/<stub>, from the root of the project.")

0 commit comments

Comments
 (0)