Skip to content

_cffi_backend.pyi FFI.__init__'s bytes #13447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
senyai opened this issue Jan 31, 2025 · 1 comment · Fixed by #13590
Closed

_cffi_backend.pyi FFI.__init__'s bytes #13447

senyai opened this issue Jan 31, 2025 · 1 comment · Fixed by #13590
Labels
stubs: false positive Type checkers report false errors

Comments

@senyai
Copy link

senyai commented Jan 31, 2025

Hi!

About this stub:
https://github.com/python/typeshed/blob/c193cd2a36839c8e6336f350397f51ce52fedd5e/stubs/cffi/_cffi_backend.pyi#L128C1-L138C19
all str in this __init__ method should be bytes. Because that's how it is when cffi is used in out-of-line mode (i.e compiled). And PyBytes_AS_STRING is called on even arguments https://github.com/python-cffi/cffi/blob/25172b84cf51cf58241f074ccd1efd9c7648cb43/src/c/cdlopen.c#L191
@srittau srittau added the stubs: false positive Type checkers report false errors label Feb 26, 2025
@srittau
Copy link
Collaborator

srittau commented Feb 26, 2025

PR welcome!

@Mr-Sunglasses Mr-Sunglasses mentioned this issue Mar 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stubs: false positive Type checkers report false errors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-13477: Fix parameter type annotations in _cffi_backend stub. Mr-Sunglasses/typeshed
2 participants
@srittau @senyai