Conformance tests: Allow TD.get(known_key) to be T | None (#1690)

Author: JelleZijlstra

conformance/results/mypy/typeddicts_type_consistency.toml

@@ -8,12 +8,10 @@ typeddicts_type_consistency.py:76: error: Incompatible types in assignment (expr
 typeddicts_type_consistency.py:77: error: Incompatible types in assignment (expression has type "B3", variable has type "dict[str, object]")  [assignment]
 typeddicts_type_consistency.py:78: error: Incompatible types in assignment (expression has type "B3", variable has type "dict[Any, Any]")  [assignment]
 typeddicts_type_consistency.py:82: error: Incompatible types in assignment (expression has type "B3", variable has type "Mapping[str, int]")  [assignment]
-typeddicts_type_consistency.py:99: error: Incompatible types in assignment (expression has type "str | None", variable has type "str")  [assignment]
-typeddicts_type_consistency.py:105: error: Incompatible types in assignment (expression has type "int | str", variable has type "int")  [assignment]
-typeddicts_type_consistency.py:124: error: Incompatible types (expression has type "int", TypedDict item "inner_key" has type "str")  [typeddict-item]
+typeddicts_type_consistency.py:101: error: Incompatible types in assignment (expression has type "str | None", variable has type "str")  [assignment]
+typeddicts_type_consistency.py:107: error: Incompatible types in assignment (expression has type "int | str", variable has type "int")  [assignment]
+typeddicts_type_consistency.py:126: error: Incompatible types (expression has type "int", TypedDict item "inner_key" has type "str")  [typeddict-item]
 """
-conformance_automated = "Fail"
+conformance_automated = "Pass"
 errors_diff = """
-Line 99: Unexpected errors ['typeddicts_type_consistency.py:99: error: Incompatible types in assignment (expression has type "str | None", variable has type "str")  [assignment]']
-Line 105: Unexpected errors ['typeddicts_type_consistency.py:105: error: Incompatible types in assignment (expression has type "int | str", variable has type "int")  [assignment]']
 """

conformance/results/pyre/typeddicts_type_consistency.toml

@@ -12,15 +12,13 @@ typeddicts_type_consistency.py:76:0 Incompatible variable type [9]: d1 is declar
 typeddicts_type_consistency.py:77:0 Incompatible variable type [9]: d2 is declared to have type `Dict[str, object]` but is used as type `B3`.
 typeddicts_type_consistency.py:78:0 Incompatible variable type [9]: d3 is declared to have type `Dict[typing.Any, typing.Any]` but is used as type `B3`.
 typeddicts_type_consistency.py:82:0 Incompatible variable type [9]: m1 is declared to have type `Mapping[str, int]` but is used as type `B3`.
-typeddicts_type_consistency.py:99:0 Incompatible variable type [9]: name3 is declared to have type `str` but is used as type `Optional[str]`.
-typeddicts_type_consistency.py:105:0 Incompatible variable type [9]: age4 is declared to have type `int` but is used as type `Union[str, int]`.
-typeddicts_type_consistency.py:124:41 TypedDict initialization error [55]: Expected type `str` for `Inner1` field `inner_key` but got `int`.
-typeddicts_type_consistency.py:150:0 Incompatible variable type [9]: o4 is declared to have type `Outer3` but is used as type `Outer2`.
+typeddicts_type_consistency.py:101:0 Incompatible variable type [9]: name3 is declared to have type `str` but is used as type `Optional[str]`.
+typeddicts_type_consistency.py:107:0 Incompatible variable type [9]: age4 is declared to have type `int` but is used as type `Union[str, int]`.
+typeddicts_type_consistency.py:126:41 TypedDict initialization error [55]: Expected type `str` for `Inner1` field `inner_key` but got `int`.
+typeddicts_type_consistency.py:152:0 Incompatible variable type [9]: o4 is declared to have type `Outer3` but is used as type `Outer2`.
 """
 conformance_automated = "Fail"
 errors_diff = """
 Line 65: Expected 1 errors
-Line 99: Unexpected errors ['typeddicts_type_consistency.py:99:0 Incompatible variable type [9]: name3 is declared to have type `str` but is used as type `Optional[str]`.']
-Line 105: Unexpected errors ['typeddicts_type_consistency.py:105:0 Incompatible variable type [9]: age4 is declared to have type `int` but is used as type `Union[str, int]`.']
-Line 150: Unexpected errors ['typeddicts_type_consistency.py:150:0 Incompatible variable type [9]: o4 is declared to have type `Outer3` but is used as type `Outer2`.']
+Line 152: Unexpected errors ['typeddicts_type_consistency.py:152:0 Incompatible variable type [9]: o4 is declared to have type `Outer3` but is used as type `Outer2`.']
 """

conformance/results/pyright/typeddicts_type_consistency.toml

@@ -20,7 +20,7 @@ typeddicts_type_consistency.py:82:25 - error: Expression of type "B3" cannot be
   "B3" is incompatible with "Mapping[str, int]"
     Type parameter "_VT_co@Mapping" is covariant, but "object" is not a subtype of "int"
       "object" is incompatible with "int" (reportAssignmentType)
-typeddicts_type_consistency.py:124:56 - error: Expression of type "dict[str, dict[str, dict[str, int]]]" cannot be assigned to declared type "Outer1"
+typeddicts_type_consistency.py:126:56 - error: Expression of type "dict[str, dict[str, dict[str, int]]]" cannot be assigned to declared type "Outer1"
   "Literal[1]" is incompatible with "str" (reportAssignmentType)
 """
 conformance_automated = "Pass"

conformance/results/pytype/typeddicts_type_consistency.toml

@@ -8,7 +8,7 @@ output = """
 File "typeddicts_type_consistency.py", line 62, in <module>: Type annotation for a3 does not match type of assignment [annotation-type-mismatch]
 File "typeddicts_type_consistency.py", line 65, in <module>: Type annotation for b3 does not match type of assignment [annotation-type-mismatch]
 File "typeddicts_type_consistency.py", line 69, in <module>: Type annotation for a3_1 does not match type of assignment [annotation-type-mismatch]
-File "typeddicts_type_consistency.py", line 124, in <module>: Type annotation for o2 does not match type of assignment [annotation-type-mismatch]
+File "typeddicts_type_consistency.py", line 126, in <module>: Type annotation for o2 does not match type of assignment [annotation-type-mismatch]
 """
 conformance_automated = "Fail"
 errors_diff = """

conformance/tests/typeddicts_type_consistency.py

@@ -96,13 +96,15 @@ class B3(TypedDict):
 
 name2: str | None = user2.get("name")
 
-name3: str = user2.get("name")
+# The spec does not say whether type checkers should adjust the return type of `.get()`
+# to exclude `None` if it is known that the key exists. Either option is acceptable.
+name3: str = user2.get("name")  # E?
 
 age2: int = user2.get("age", 42)
 
 age3: int | str = user2.get("age", "42")
 
-age4: int = user2.get("age", "42")
+age4: int = user2.get("age", "42")  # E?
 
 # Test nested TypedDicts.
 class Inner1(TypedDict):