Skip to content

Commit a12ccc5

Browse files
committed
Changed method of random number generation, although still not getting consistent results
1 parent f1974f8 commit a12ccc5

13 files changed

+18069
-65
lines changed

evaluation/posts/2024_05_22/index.qmd

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@ categories: [setup, read, scope]
77

88
::: {.callout-note}
99

10-
## Total time elapsed
10+
## Time elapsed
1111

12-
1h 13m (3%)
12+
1h 13m today (total: 3%)
1313

1414
:::
1515

Loading
Loading

evaluation/posts/2024_05_23/index.qmd

Lines changed: 19 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@ categories: [read, reproduce]
77

88
::: {.callout-note}
99

10-
## Total time elapsed
10+
## Time elapsed
1111

12-
TBC
12+
3h 23m today (total: 11.5%)
1313

1414
:::
1515

@@ -275,7 +275,7 @@ However, this definitely has **not** fixed the issue! Still varying - and I woul
275275

276276
<mark>test! idea is to check that you are getting the same results between runs</mark>
277277

278-
### 15.23- Reproduction
278+
### 15.23-16.35 Reproduction
279279

280280
::: {.callout-tip}
281281
## Random seeds
@@ -306,6 +306,20 @@ I thought best option is to switch to using it how it is uses in the [treat-sim
306306
So next things I did -
307307

308308
* Delete the NormalParams and UniformParams classes as not used - checked if still run fine which it did.
309+
* Modified the Normal and Uniform so the random number sampling matches up with [treat-sim model docs](https://pythonhealthdatascience.github.io/stars-simpy-example-docs/content/02_model_code/04_model.html#distribution-classes), and Scenario class so it's similar (class itself is just set up a little differently)
310+
* In .ipynb, removed the parameters from Scenario() that were identical to those when Scenario is created (except seed setting)
311+
312+
Then ran it twice again (this time just with 5 replications). Not matching up yet -
313+
314+
Run 1 with new random method:
315+
316+
<img src="displaced_base_3_month_newclass1.png" width="500" />
317+
318+
Run 2:
319+
320+
<img src="displaced_base_3_month_newclass2.png" width="500" />
321+
322+
<mark>Updating documentation after I've made changes to it - not priority during reproduction unless feel important to make obvious, but priority during the research compendium stage, to make sure documetnation is all as it should be</mark> or just do as go along...
309323

310324
## Timings
311325

@@ -324,7 +338,8 @@ times = [
324338
('12.10', '12.16'),
325339
('12.19', '12.29'),
326340
('13.26', '13.52'),
327-
('14.19', '15.12')]
341+
('14.19', '15.12'),
342+
('15.23', '16.35')]
328343
# --------------------------------------------------------------
329344
330345
FMT = '%H.%M'

reproduction/example.ipynb

Lines changed: 15 additions & 15 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)