Additional refactors

Author: MU-Software

runtime/chalicelib/external_api/toast_alimtalk.py

@@ -61,6 +61,7 @@ class MessageOption(pydantic.BaseModel):
     statsId: str | None = pydantic.Field(max_length=8, default=None)
 
     @pydantic.field_validator("requestDate", mode="before")
+    @classmethod
     def validate_request_date(cls, v: datetime.datetime | None) -> datetime.datetime | None:
         if v and v.date() - datetime.date.today() > datetime.timedelta(days=60):
             raise ValueError("The request date should not be more than 60 days in the future.")

runtime/chalicelib/send_manager/__interface__.py

@@ -16,10 +16,12 @@ class SendRequest(pydantic.BaseModel):
 class SendManagerInterface:
     service_name: typing.ClassVar[str]
     template_manager: typing.ClassVar[template_mgr_interface.TemplateManagerInterface]
+    send_request_cls: typing.ClassVar[type[SendRequest]]
 
     initialized: typing.ClassVar[bool]
 
     def __init_subclass__(cls) -> None:
         type_util.check_classvar_initialized(cls, ["service_name", "template_manager"])
 
-    def send(self, request: SendRequest) -> dict[str, str | None]: ...
+    def send(self, request: SendRequest) -> dict[str, str | None]:
+        raise NotImplementedError("This method must be implemented in the subclass.")

runtime/chalicelib/send_manager/aws_ses.py

@@ -8,6 +8,7 @@
 
 class AWSSESSendManager(sendmgr_interface.SendManagerInterface):
     template_manager = aws_ses_template_mgr.aws_ses_template_manager
+    send_request_cls = sendmgr_interface.SendRequest
 
     service_name = "aws_ses"
     initialized = True

runtime/chalicelib/send_manager/telegram_botmessaging.py

@@ -12,6 +12,7 @@
 
 class TelegramBotMessagingSender(sendmgr_interface.SendManagerInterface):
     template_manager = telegram_template_mgr.telegram_template_manager
+    send_request_cls: sendmgr_interface.SendRequest
     client = telegram_client.TelegramBotMessagingClient()
 
     service_name = "telegram_botmessaging"

runtime/chalicelib/send_manager/toast_alimtalk.py

@@ -20,6 +20,7 @@ def _send_request_to_toast_request_payload(req: sendmgr_interface.SendRequest) -
 
 class ToastAlimtalkSendManager(sendmgr_interface.SendManagerInterface):
     template_manager = toast_alimtalk_template_mgr.toast_alimtalk_template_manager
+    send_request_cls: sendmgr_interface.SendRequest
     client = toast_alimtalk_client.ToastAlimTalkClient()
 
     service_name = "toast_alimtalk"

runtime/chalicelib/sender/firebase_cloudmessaging.py

@@ -54,6 +54,7 @@ class FirebaseCloudMessaging(pydantic.BaseModel):
     model_config = pydantic.ConfigDict(arbitrary_types_allowed=True)
 
     @pydantic.field_validator("data", mode="before")
+    @classmethod
     def validate_data(cls, data: dict) -> dict:
         # All keys and values in data must be a string in firebase cloud messaging.
         # We'll try to type cast all values to json compatible string.

runtime/chalicelib/template_manager/__interface__.py

@@ -44,20 +44,26 @@ def __init_subclass__(cls, check_classvar_initialized: bool = True) -> None:
             type_util.check_classvar_initialized(cls, ["service_name", "template_structure_cls"])
 
     @property
-    def initialized(self) -> bool: ...
+    def initialized(self) -> bool:
+        raise NotImplementedError("This method must be implemented in the subclass.")
 
     def check_template_valid(self, template_data: TemplateType) -> bool:
         return bool(self.template_structure_cls.model_validate(template_data))
 
-    def list(self) -> list[TemplateInformation]: ...
+    def list(self) -> list[TemplateInformation]:
+        raise NotImplementedError("This method must be implemented in the subclass.")
 
-    def retrieve(self, template_code: str) -> TemplateInformation | None: ...
+    def retrieve(self, template_code: str) -> TemplateInformation | None:
+        raise NotImplementedError("This method must be implemented in the subclass.")
 
-    def create(self, template_code: str, template_data: TemplateType) -> TemplateInformation: ...
+    def create(self, template_code: str, template_data: TemplateType) -> TemplateInformation:
+        raise NotImplementedError("This method must be implemented in the subclass.")
 
-    def update(self, template_code: str, template_data: TemplateType) -> TemplateInformation: ...
+    def update(self, template_code: str, template_data: TemplateType) -> TemplateInformation:
+        raise NotImplementedError("This method must be implemented in the subclass.")
 
-    def delete(self, template_code: str) -> None: ...
+    def delete(self, template_code: str) -> None:
+        raise NotImplementedError("This method must be implemented in the subclass.")
 
     def render(
         self,