Lint.

Author: itamarst

memapi/src/lib.rs

@@ -16,19 +16,22 @@ pub extern "C" fn pymemprofile_free_allocation(address: usize) {
     memorytracking::free_allocation(address);
 }
 
+/// # Safety
+/// Intended for use from C APIs, what can I say.
 #[no_mangle]
-pub extern "C" fn pymemprofile_start_call(file_name: *const c_char, func_name: *const c_char) {
-    let name = unsafe {
-        format!(
-            "{}:{}",
-            CStr::from_ptr(file_name)
-                .to_str()
-                .expect("Function name wasn't UTF-8"),
-            CStr::from_ptr(func_name)
-                .to_str()
-                .expect("Function name wasn't UTF-8")
-        )
-    };
+pub unsafe extern "C" fn pymemprofile_start_call(
+    file_name: *const c_char,
+    func_name: *const c_char,
+) {
+    let name = format!(
+        "{}:{}",
+        CStr::from_ptr(file_name)
+            .to_str()
+            .expect("Function name wasn't UTF-8"),
+        CStr::from_ptr(func_name)
+            .to_str()
+            .expect("Function name wasn't UTF-8")
+    );
     memorytracking::start_call(name);
 }
 
@@ -42,14 +45,14 @@ pub extern "C" fn pymemprofile_reset() {
     memorytracking::reset();
 }
 
+/// # Safety
+/// Intended for use from C APIs, what can I say.
 #[no_mangle]
-pub extern "C" fn pymemprofile_dump_peak_to_flamegraph(path: *const c_char) {
-    let path = unsafe {
-        CStr::from_ptr(path)
-            .to_str()
-            .expect("Path wasn't UTF-8")
-            .to_string()
-    };
+pub unsafe extern "C" fn pymemprofile_dump_peak_to_flamegraph(path: *const c_char) {
+    let path = CStr::from_ptr(path)
+        .to_str()
+        .expect("Path wasn't UTF-8")
+        .to_string();
     memorytracking::dump_peak_to_flamegraph(&path);
 }
 

memapi/src/memorytracking.rs

@@ -25,8 +25,8 @@ impl Callstack {
         self.calls.pop();
     }
 
-    fn to_string(&self) -> String {
-        if self.calls.len() == 0 {
+    fn as_string(&self) -> String {
+        if self.calls.is_empty() {
             "[No Python stack]".to_string()
         } else {
             self.calls.iter().join(";")
@@ -89,7 +89,7 @@ impl AllocationTracker {
         let mut by_call: collections::HashMap<String, usize> = collections::HashMap::new();
         let peak_allocations = &self.peak_allocations;
         for Allocation { callstack, size } in peak_allocations.values() {
-            let callstack = callstack.to_string();
+            let callstack = callstack.as_string();
             let entry = by_call.entry(callstack).or_insert(0);
             *entry += size;
         }
@@ -174,7 +174,7 @@ fn write_flamegraph<'a, I: IntoIterator<Item = &'a str>>(
         peak_bytes as f64 / (1024.0 * 1024.0)
     );
     let mut options = flamegraph::Options {
-        title: title,
+        title,
         direction: flamegraph::Direction::Inverted,
         count_name: "KiB".to_string(),
         colors: flamegraph::color::Palette::Basic(flamegraph::color::BasicPalette::Mem),