Skip to content

Commit 9aedbeb

Browse files
authored
Arm backend: Make the CI green by not testing Dedicated_Sram for the Ethos-U85 (#10973)
Temporary solution to the problem in #10958 The arm_executor_runner.cpp need to declare the ethosu_fast_scratch array and pass it onto to the EthosUBackend.cpp. It is important that for Shared_Sram, the ethosu_fast_scratch is nullptr and for Dedicated_Sram it points to the fast memory array.
1 parent b2f9ef9 commit 9aedbeb

File tree

4 files changed

+7
-4
lines changed

4 files changed

+7
-4
lines changed

backends/arm/scripts/build_executor_runner.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ then
103103
memory_mode="Shared_Sram"
104104
if [[ ${target} =~ "ethos-u85" ]]
105105
then
106-
memory_mode="Dedicated_Sram_384KB"
106+
memory_mode="Sram_Only"
107107
fi
108108
fi
109109

backends/arm/test/test_arm_baremetal.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,10 @@ test_models_ethos-u85() { # End to End model tests using model_test.py
210210
python3 backends/arm/test/test_model.py --test_output=arm_test/test_model --target=ethos-u85-512 --model=mv3 --extra_flags="-DET_ATOL=5.00 -DET_RTOL=5.00"
211211
python3 backends/arm/test/test_model.py --test_output=arm_test/test_model --target=ethos-u85-128 --model=lstm --extra_flags="-DET_ATOL=0.03 -DET_RTOL=0.03"
212212
python3 backends/arm/test/test_model.py --test_output=arm_test/test_model --target=ethos-u85-128 --model=w2l --extra_flags="-DET_ATOL=0.01 -DET_RTOL=0.01"
213-
python3 backends/arm/test/test_model.py --test_output=arm_test/test_model --target=ethos-u85-256 --model=ic4 --extra_flags="-DET_ATOL=0.8 -DET_RTOL=0.8" --timeout=2400
213+
# Temporarily not test inception_v4 on Ethos-U85. To support inception_v4 properly on Ethos-U85, we need to run the model in Dedicated_Sram memory mode with
214+
# 384KB(or another amount lower than 2MB) of SRAM passed as fast scratch area. The PR adding support for Dedicated_Sram(https://github.com/pytorch/executorch/pull/10714)
215+
# was reverted due to a change required in an internal variant of the examples/arm/executor_runner/arm_executor_runner.cpp
216+
# python3 backends/arm/test/test_model.py --test_output=arm_test/test_model --target=ethos-u85-256 --model=ic4 --extra_flags="-DET_ATOL=0.8 -DET_RTOL=0.8" --timeout=2400
214217

215218
echo "${TEST_SUITE_NAME}: PASS"
216219
}

backends/arm/test/test_model.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ def get_args():
8181
if "u55" in args.target:
8282
args.memory_mode = "Shared_Sram"
8383
elif "u85" in args.target:
84-
args.memory_mode = "Dedicated_Sram_384KB"
84+
args.memory_mode = "Sram_Only"
8585
else:
8686
raise RuntimeError(f"Invalid target name {args.target}")
8787

examples/arm/run.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ then
110110
memory_mode="Shared_Sram"
111111
if [[ ${target} =~ "ethos-u85" ]]
112112
then
113-
memory_mode="Dedicated_Sram_384KB"
113+
memory_mode="Sram_Only"
114114
fi
115115
fi
116116

0 commit comments

Comments
 (0)