Skip to content

Commit 1c223ac

Browse files
authored
Remove pre-cxx-abi mention for libtorch builds (#1976)
* Remove pre-cxx-abi mention * remove from nightly * Revert "remove from nightly" This reverts commit 54db730. * fixes * fix * fix
1 parent 239fdb3 commit 1c223ac

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

Diff for: published_versions.json

+1-5
Original file line numberDiff line numberDiff line change
@@ -52,28 +52,24 @@
5252
"accnone": {
5353
"note": null,
5454
"versions": {
55-
"Download here (Pre-cxx11 ABI):": "https://download.pytorch.org/libtorch/nightly/cpu/libtorch-shared-with-deps-latest.zip",
5655
"Download here (cxx11 ABI):": "https://download.pytorch.org/libtorch/nightly/cpu/libtorch-cxx11-abi-shared-with-deps-latest.zip"
5756
}
5857
},
5958
"cuda.x": {
6059
"note": null,
6160
"versions": {
62-
"Download here (Pre-cxx11 ABI):": "https://download.pytorch.org/libtorch/nightly/cu118/libtorch-shared-with-deps-latest.zip",
6361
"Download here (cxx11 ABI):": "https://download.pytorch.org/libtorch/nightly/cu118/libtorch-cxx11-abi-shared-with-deps-latest.zip"
6462
}
6563
},
6664
"cuda.y": {
6765
"note": null,
6866
"versions": {
69-
"Download here (Pre-cxx11 ABI):": "https://download.pytorch.org/libtorch/nightly/cu126/libtorch-shared-with-deps-latest.zip",
7067
"Download here (cxx11 ABI):": "https://download.pytorch.org/libtorch/nightly/cu126/libtorch-cxx11-abi-shared-with-deps-latest.zip"
7168
}
7269
},
7370
"cuda.z": {
7471
"note": null,
7572
"versions": {
76-
"Download here (Pre-cxx11 ABI):": "https://download.pytorch.org/libtorch/nightly/cu128/libtorch-shared-with-deps-latest.zip",
7773
"Download here (cxx11 ABI):": "https://download.pytorch.org/libtorch/nightly/cu128/libtorch-cxx11-abi-shared-with-deps-latest.zip"
7874
}
7975
},
@@ -5863,4 +5859,4 @@
58635859
}
58645860
}
58655861
}
5866-
}
5862+
}

Diff for: scripts/gen_quick_start_module.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -157,8 +157,9 @@ def update_versions(versions, release_matrix, release_version):
157157
if x["libtorch_variant"] == "shared-with-deps"
158158
}
159159
if instr["versions"] is not None:
160-
for ver in [PRE_CXX11_ABI, CXX11_ABI]:
161-
if gpu_arch_type == "rocm" and ver == PRE_CXX11_ABI:
160+
for ver in [CXX11_ABI, PRE_CXX11_ABI]:
161+
# temporarily apply removal of cxx11 abi only to nightly and rocm builds
162+
if ver == PRE_CXX11_ABI and (release_version == "nightly" or gpu_arch_type == "rocm"):
162163
continue
163164
else:
164165
instr["versions"][LIBTORCH_DWNL_INSTR[ver]] = (

0 commit comments

Comments
 (0)