Skip to content

Commit 1f863f9

Browse files
committed
Remove evil session_mocker usage to prevent test cross talking
1 parent 130a29e commit 1f863f9

File tree

1 file changed

+14
-20
lines changed

1 file changed

+14
-20
lines changed

test/pytest/test_example_micro_batching.py

+14-20
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
import shutil
55
from argparse import Namespace
66
from pathlib import Path
7+
from unittest.mock import MagicMock, patch
8+
from zipfile import ZIP_STORED, ZipFile
79

810
import pytest
911
import requests
@@ -81,9 +83,7 @@ def serialized_file(work_dir):
8183
@pytest.fixture(
8284
scope="module", name="mar_file_path", params=["yaml_config", "no_config"]
8385
)
84-
def create_mar_file(
85-
work_dir, session_mocker, serialized_file, model_archiver, model_name, request
86-
):
86+
def create_mar_file(work_dir, serialized_file, model_archiver, model_name, request):
8787
mar_file_path = Path(work_dir).joinpath(model_name + ".mar")
8888

8989
name_file = REPO_ROOT_DIR.joinpath(
@@ -132,25 +132,19 @@ def create_mar_file(
132132
config_file=config_file,
133133
)
134134

135-
mock = session_mocker.MagicMock()
136-
mock.parse_args = session_mocker.MagicMock(return_value=args)
137-
session_mocker.patch(
138-
"archiver.ArgParser.export_model_args_parser", return_value=mock
139-
)
140-
141-
# Using ZIP_STORED instead of ZIP_DEFLATED reduces test runtime from 54 secs to 10 secs
142-
from zipfile import ZIP_STORED, ZipFile
143-
144-
session_mocker.patch(
145-
"model_archiver.model_packaging_utils.zipfile.ZipFile",
146-
lambda x, y, _: ZipFile(x, y, ZIP_STORED),
147-
)
148-
149-
model_archiver.generate_model_archive()
135+
mock = MagicMock()
136+
mock.parse_args = MagicMock(return_value=args)
137+
with patch("archiver.ArgParser.export_model_args_parser", return_value=mock):
138+
# Using ZIP_STORED instead of ZIP_DEFLATED reduces test runtime from 54 secs to 10 secs
139+
with patch(
140+
"model_archiver.model_packaging_utils.zipfile.ZipFile",
141+
lambda x, y, _: ZipFile(x, y, ZIP_STORED),
142+
):
143+
model_archiver.generate_model_archive()
150144

151-
assert mar_file_path.exists()
145+
assert mar_file_path.exists()
152146

153-
yield mar_file_path.as_posix()
147+
yield mar_file_path.as_posix()
154148

155149
# Clean up files
156150
mar_file_path.unlink(missing_ok=True)

0 commit comments

Comments
 (0)