Skip to content

Commit 7cecea2

Browse files
jettifychauhangdhanainme
authored
socket.send does not guarantee that all data will be send. (#765)
sendall should be used instead. Co-authored-by: Geeta Chauhan <[email protected]> Co-authored-by: dhanainme <[email protected]>
1 parent f1e5356 commit 7cecea2

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

ts/model_service_worker.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -111,12 +111,12 @@ def handle_connection(self, cl_socket):
111111
pr.enable()
112112
if cmd == b'I':
113113
resp = service.predict(msg)
114-
cl_socket.send(resp)
114+
cl_socket.sendall(resp)
115115
elif cmd == b'L':
116116
service, result, code = self.load_model(msg)
117117
resp = bytearray()
118118
resp += create_load_model_response(code, result)
119-
cl_socket.send(resp)
119+
cl_socket.sendall(resp)
120120
if code != 200:
121121
raise RuntimeError("{} - {}".format(code, result))
122122
else:

ts/tests/unit_tests/test_model_service_worker.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -170,4 +170,4 @@ def test_handle_connection(self, patches, model_service_worker):
170170
with pytest.raises(ValueError, match=r"Received unknown command.*"):
171171
model_service_worker.handle_connection(cl_socket)
172172

173-
cl_socket.send.assert_called()
173+
cl_socket.sendall.assert_called()

0 commit comments

Comments
 (0)