Skip to content

Commit 37c4b81

Browse files
authored
Removes fused_rmsnorm (#826)
Context in #825.
1 parent 8824727 commit 37c4b81

10 files changed

Lines changed: 7 additions & 369 deletions

File tree

scripts/estimate/estimation.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -33,17 +33,6 @@ def estimate_memory(job_config: JobConfig):
3333
# Get the world size
3434
world_size = int(os.environ["WORLD_SIZE"])
3535

36-
# fake tensor doesn't work with fused rmsnorm
37-
if (
38-
job_config.model.norm_type == "fused_rmsnorm"
39-
and not job_config.memory_estimation.disable_fake_mode
40-
):
41-
logger.info(
42-
"Fused RMSNorm is not supported yet under fake estimation mode. "
43-
"Switching to rmsnorm."
44-
)
45-
job_config.model.norm_type = "rmsnorm"
46-
4736
if job_config.model.norm_type == "compiled_rmsnorm":
4837
logger.info("Compiled RMSNorm is not supported yet. Switching to RMSNorm.")
4938
job_config.model.norm_type = "rmsnorm"

tests/integration_tests.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -94,16 +94,6 @@ def build_test_list():
9494
"2D compile",
9595
"2d_compile",
9696
),
97-
OverrideDefinitions(
98-
[
99-
[
100-
"--training.tensor_parallel_degree 2",
101-
"--model.norm_type=fused_rmsnorm",
102-
],
103-
],
104-
"2D eager with fused_rmsnorm",
105-
"2d_eager_fused_rmsnorm",
106-
),
10797
OverrideDefinitions(
10898
[
10999
[

tests/unit_tests/test_fused_rms_norm_dtensor.py

Lines changed: 0 additions & 72 deletions
This file was deleted.

torchtitan/config_manager.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,8 @@ def __init__(self):
174174
"--model.norm_type",
175175
type=str,
176176
default="rmsnorm",
177-
help="Type of layer normalization to use [layernorm, np_layernorm, rmsnorm, fused_rmsnorm]",
177+
choices=["layernorm", "np_layernorm", "rmsnorm"],
178+
help="Type of layer normalization to use [layernorm, np_layernorm, rmsnorm]",
178179
)
179180
self.parser.add_argument(
180181
"--model.tokenizer_path",

0 commit comments

Comments
 (0)