Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Janus-Pro series of model #2306

Closed
Ankur-singh opened this issue Jan 28, 2025 · 2 comments
Closed

Support for Janus-Pro series of model #2306

Ankur-singh opened this issue Jan 28, 2025 · 2 comments

Comments

@Ankur-singh
Copy link
Contributor

Any thoughts on supporting Janus Series VLMs?

Official Git Repo: https://github.com/deepseek-ai/Janus

@felipemello1
Copy link
Contributor

felipemello1 commented Jan 30, 2025

Hey @Ankur-singh , thanks for bringing it up! Janus look nice, but It is a bit hard for us to onboard new models at the moment. We have some members on PTO and there is some work we have to prioritize first. I see that you have been helping on a lot of issues lately. In case you are curious, I listed some of these below, in no order of importance:

  • Instantiating tokenizers using tokenizer config, instead of creating a new torchtune tokenizer per model -- this will make onboarding models easier
  • Fast unit testing with increased coverage (permutations of quantization, performance flags, distributed, lora, etc) -- this will make onboarding models easier
  • Cleaner / moduralized recipes
  • Fast inference
  • Efficient RL // parallel faster inference (instead of train -> inference -> train)

@felipemello1
Copy link
Contributor

Added a bit more detail to the response :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants