Skip flaky MacOS tests (#9488)

Author: NicolasHug

test/test_ops.py

@@ -407,7 +407,7 @@ def bilinear_interpolate(data, y, x, snap_border=False):
 
 
 class TestRoIAlign(RoIOpTester):
-    mps_backward_atol = 6e-2
+    mps_backward_atol = 1e-1
 
     def fn(self, x, rois, pool_h, pool_w, spatial_scale=1, sampling_ratio=-1, aligned=False, **kwargs):
         return ops.RoIAlign(
@@ -1244,6 +1244,20 @@ def xfail_if_mps(x):
     return x
 
 
+def skip_if_mps(x):
+    mps_skip_param = pytest.param("mps", marks=(pytest.mark.needs_mps, pytest.mark.skip(reason="Flaky on MPS")))
+    new_pytestmark = []
+    for mark in x.pytestmark:
+        if isinstance(mark, pytest.Mark) and mark.name == "parametrize":
+            if mark.args[0] == "device":
+                params = cpu_and_cuda() + (mps_skip_param,)
+                new_pytestmark.append(pytest.mark.parametrize("device", params))
+                continue
+        new_pytestmark.append(mark)
+    x.__dict__["pytestmark"] = new_pytestmark
+    return x
+
+
 optests.generate_opcheck_tests(
     testcase=TestDeformConv,
     namespaces=["torchvision"],
@@ -1252,6 +1266,7 @@ def xfail_if_mps(x):
     additional_decorators={
         "test_aot_dispatch_dynamic__test_forward": [xfail_if_mps],
         "test_autograd_registration__test_forward": [xfail_if_mps],
+        "test_faketensor__test_forward": [skip_if_mps],
     },
     test_utils=OPTESTS,
 )

test/test_transforms_v2.py

@@ -3843,6 +3843,10 @@ def test_functional_image_correctness(self, dtype, device):
     @pytest.mark.parametrize("device", cpu_and_cuda())
     @pytest.mark.parametrize("seed", list(range(5)))
     def test_transform_image_correctness(self, param, value, dtype, device, seed):
+        if sys.platform == "darwin" and value == "random" and dtype == torch.uint8:
+            # Mismatched elements: 10 / 561 (1.8%)
+            pytest.skip("Non-deterministic RNG behavior on macOS for random erase with uint8")
+
         transform = transforms.RandomErasing(**{param: value}, p=1)
 
         image = make_image(dtype=dtype, device=device)