Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New event type for executing savings plan not recognized #194

Open
wolfs opened this issue Feb 15, 2025 · 1 comment
Open

New event type for executing savings plan not recognized #194

wolfs opened this issue Feb 15, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@wolfs
Copy link

wolfs commented Feb 15, 2025

Description of the bug

Today I tried to export the transactions from the last week. Though the account_transactions.csv files only contained the header.

After inspecting events_with_documents.json, I saw that the event type changed from SAVINGS_PLAN_INVOICE_CREATED to trading_savingsplan_executed. Manually editing the event type in the json and then running export_transactions results in a csv file with contents.

Now only the numbers for the shares seem to have the wrong comma. They show up as 1,234,456 instead of 1.234456. Should I open a separate bug for that?

To Reproduce
Steps to reproduce the behavior:

  1. uvx pytr@latest dl_docs --last_days=7 docs
  2. docs/account_transactions.csv only has headers, even though three savings plan executions have been logged.

Expected behavior

transactions.csv contains the savings transactions.

Environment

  • OS: macOS
  • pytr version: 0.4.1

Additional context

The transactions from two weeks ago still show up correctly, only the ones from last week (Feb 10) do not show up.

@wolfs wolfs added the bug Something isn't working label Feb 15, 2025
@RealCLanger
Copy link
Collaborator

I believe this would be fixed with my PR #193. However, still working on figuring out the best way for number parsing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants