From 4fa7fbd32bca523dc305f17d76285f6658604582 Mon Sep 17 00:00:00 2001 From: Marcus Fey Date: Thu, 16 Jan 2025 16:30:15 +0100 Subject: [PATCH 1/3] add newline to last line of portfolio_to_csv output --- pytr/portfolio.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pytr/portfolio.py b/pytr/portfolio.py index fc805ec..64e7ddf 100644 --- a/pytr/portfolio.py +++ b/pytr/portfolio.py @@ -89,7 +89,7 @@ def portfolio_to_csv(self, output_path): with open(output_path, 'w', encoding='utf-8') as f: f.write('Name;ISIN;quantity;avgCost;netValue\n') - f.write('\n'.join(csv_lines)) + f.write('\n'.join(csv_lines) + ('\n' if csv_lines else '')) print(f'Wrote {len(csv_lines) + 1} lines to {output_path}') From 11fac4934e8efb7602d12f8c698110f0c22f982c Mon Sep 17 00:00:00 2001 From: Niklas Rosenstein Date: Tue, 11 Feb 2025 10:50:16 +0100 Subject: [PATCH 2/3] Update pytr/portfolio.py --- pytr/portfolio.py | 1 - 1 file changed, 1 deletion(-) diff --git a/pytr/portfolio.py b/pytr/portfolio.py index 5ac4346..697e3f2 100644 --- a/pytr/portfolio.py +++ b/pytr/portfolio.py @@ -97,7 +97,6 @@ def portfolio_to_csv(self, output_path): f"{pos['name']};{pos['instrumentId']};{float(pos['netSize']):>10.3f};{float(pos['averageBuyIn']):.2f};{float(pos['netValue']):.2f}" ) - with open(output_path, "w", encoding="utf-8") as f: f.write("Name;ISIN;quantity;avgCost;netValue\n") f.write("\n".join(csv_lines) + ('\n' if csv_lines else '')) From 413551b75b3c3127ef8d650428d59b3d3b2a231c Mon Sep 17 00:00:00 2001 From: Niklas Rosenstein Date: Tue, 11 Feb 2025 11:01:31 +0100 Subject: [PATCH 3/3] ruff format --- pytr/portfolio.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pytr/portfolio.py b/pytr/portfolio.py index 24f90d6..3b308a6 100644 --- a/pytr/portfolio.py +++ b/pytr/portfolio.py @@ -89,7 +89,7 @@ def portfolio_to_csv(self, output_path): with open(output_path, "w", encoding="utf-8") as f: f.write("Name;ISIN;quantity;avgCost;netValue\n") - f.write("\n".join(csv_lines) + ('\n' if csv_lines else '')) + f.write("\n".join(csv_lines) + ("\n" if csv_lines else "")) print(f"Wrote {len(csv_lines) + 1} lines to {output_path}")