Use view instead of join (#608)

* use view instead of join

* use list instead of collection

Co-authored-by: steffengreiner <[email protected]>

---------

Co-authored-by: steffengreiner <[email protected]>

Author: KochTobi

project-management-infrastructure/src/main/java/life/qbic/projectmanagement/infrastructure/project/ProjectOverviewLookupImplementation.java

@@ -1,6 +1,5 @@
 package life.qbic.projectmanagement.infrastructure.project;
 
-import jakarta.persistence.criteria.Join;
 import java.util.Collection;
 import java.util.List;
 import java.util.Objects;
@@ -72,11 +71,11 @@ private Specification<ProjectOverview> generateProjectOverviewSpecification(
         filter);
     Specification<ProjectOverview> hasPxpMeasurements = ProjectOverviewSpec.hasPxPMeasurements(
         filter);
-    Specification<ProjectOverview> isInCollaboratorNames = ProjectOverviewSpec.isInCollaboratorNames(
-        filter);
+//    Specification<ProjectOverview> isInCollaboratorNames = ProjectOverviewSpec.isInCollaboratorNames(
+//        filter);
     Specification<ProjectOverview> filterSpecification = Specification.anyOf(isProjectTitle,
         isProjectCode, isLastModifiedDate, isPrincipalInvestigator, isResponsiblePerson,
-        hasNgsMeasurements, hasPxpMeasurements, isInCollaboratorNames);
+        hasNgsMeasurements, hasPxpMeasurements/*, isInCollaboratorNames*/);
     return Specification.where(isBlankSpec)
         .and(containsProjectId)
         .and(filterSpecification)
@@ -167,12 +166,12 @@ public static Specification<ProjectOverview> hasPxPMeasurements(String filter) {
       };
     }
 
-    public static Specification<ProjectOverview> isInCollaboratorNames(String filter) {
-      return (root, query, builder) -> {
-        Join<ProjectOverview, String> memberJoin = root.join("collaboratorUserNames");
-        return builder.like(memberJoin, "%" + filter + "%");
-      };
-    }
+//    public static Specification<ProjectOverview> isInCollaboratorNames(String filter) {
+//      return (root, query, builder) -> {
+//        Join<ProjectOverview, String> memberJoin = root.join("collaboratorUserNames");
+//        return builder.like(memberJoin, "%" + filter + "%");
+//      };
+//    }
 
   }
 

project-management/src/main/java/life/qbic/projectmanagement/application/CollaboratorUserNamesConverter.java

@@ -0,0 +1,29 @@
+package life.qbic.projectmanagement.application;
+
+import jakarta.persistence.AttributeConverter;
+import jakarta.persistence.Converter;
+import java.util.Arrays;
+import java.util.List;
+
+/**
+ * Converts a string of comma separated usernames to a list of usernames.
+ *
+ * @since 1.0.0
+ */
+@Converter(autoApply = false)
+public class CollaboratorUserNamesConverter implements
+    AttributeConverter<List<String>, String> {
+
+  @Override
+  public String convertToDatabaseColumn(List<String> attribute) {
+    return String.join(", ", attribute);
+  }
+
+  @Override
+  public List<String> convertToEntityAttribute(String dbData) {
+    return Arrays.stream(dbData.split(","))
+        .map(String::strip)
+        .toList();
+  }
+
+}

project-management/src/main/java/life/qbic/projectmanagement/application/ProjectOverview.java

@@ -1,16 +1,14 @@
 package life.qbic.projectmanagement.application;
 
-import jakarta.persistence.CollectionTable;
 import jakarta.persistence.Column;
-import jakarta.persistence.ElementCollection;
+import jakarta.persistence.Convert;
 import jakarta.persistence.EmbeddedId;
 import jakarta.persistence.Entity;
-import jakarta.persistence.FetchType;
-import jakarta.persistence.JoinColumn;
 import jakarta.persistence.Table;
 import java.time.Instant;
 import java.util.ArrayList;
 import java.util.Collection;
+import java.util.List;
 import life.qbic.projectmanagement.domain.model.project.Project;
 import life.qbic.projectmanagement.domain.model.project.ProjectId;
 import org.hibernate.annotations.Immutable;
@@ -54,9 +52,11 @@ public class ProjectOverview {
   @Column(name = "amountPxpMeasurements")
   private String pxpMeasurementCount;
 
-  @ElementCollection(targetClass = String.class, fetch = FetchType.EAGER)
-  @CollectionTable(name = "project_usernames", joinColumns = @JoinColumn(name = "projectId"))
-  private Collection<String> collaboratorUserNames = new ArrayList<>();
+  @Convert(converter = CollaboratorUserNamesConverter.class)
+//  @ElementCollection(targetClass = String.class, fetch = FetchType.EAGER)
+//  @CollectionTable(name = "project_usernames", joinColumns = @JoinColumn(name = "projectId"))
+  @Column(name = "usernames")
+  private List<String> collaboratorUserNames = new ArrayList<>();
 
   protected ProjectOverview() {