Implement adding and deletion.of experimental variables (#1123)

* Implement adding of experimental variables

* Fix test

* Remove log statement

* remove unused code

* Make UI use async service for variable creation

* Make UI use async service for variable creation

* Add overloaded constructor

Co-authored-by: Sven F. <[email protected]>

* Immutable record lists

Co-authored-by: Sven F. <[email protected]>

* extract predicate

Co-authored-by: Sven F. <[email protected]>

* use var

Co-authored-by: Sven F. <[email protected]>

* throw instead of empty body

Co-authored-by: Sven F. <[email protected]>

* use contextWrite instead of transform

* Introduce ExperimentDeletionRequest and ExperimentDeletionResponse

* Start implementing delete experimental variables

* Implement variable deletion

* Add back retry

* Remove deletion from update

* remove impossible case

---------

Co-authored-by: KochTobi <[email protected]>
Co-authored-by: Sven F. <[email protected]>

Author: KochTobi

project-management/src/main/java/life/qbic/projectmanagement/application/api/AsyncProjectService.java

@@ -8,7 +8,6 @@
 import java.util.Collection;
 import java.util.List;
 import java.util.Map;
-import java.util.Objects;
 import java.util.Optional;
 import java.util.Set;
 import java.util.UUID;
@@ -123,6 +122,9 @@ public interface AsyncProjectService {
    */
   Mono<ProjectDeletionResponse> delete(ProjectDeletionRequest request);
 
+
+  Mono<ExperimentDeletionResponse> delete(ExperimentDeletionRequest request);
+
   /**
    * Submits a project creation request and returns a {@link Mono<ProjectCreationResponse>}
    * immediately.
@@ -376,7 +378,7 @@ sealed interface ProjectUpdateResponseBody permits FundingInformation,
 
   sealed interface ExperimentUpdateRequestBody permits ConfoundingVariableAdditions,
       ConfoundingVariableDeletions, ConfoundingVariableUpdates, ExperimentDescription,
-      ExperimentalGroups, ExperimentalVariableAdditions, ExperimentalVariableDeletions {
+      ExperimentalGroups, ExperimentalVariableAdditions {
 
   }
 
@@ -428,6 +430,15 @@ sealed interface ProjectDeletionRequestBody permits FundingDeletion,
 
   }
 
+  sealed interface ExperimentDeletionRequestBody permits ExperimentalVariableDeletions {
+
+  }
+
+
+  sealed interface ExperimentDeletionResponseBody permits ExperimentalVariables {
+
+  }
+
   /**
    * Container for passing information in an {@link ProjectUpdateRequestBody} or
    * {@link ProjectUpdateResponseBody}.
@@ -500,7 +511,11 @@ record PrincipalInvestigator(ProjectContact contact) implements ProjectUpdateReq
    * @param unit   the unit of the experimental variable. Can be null if no unit is set
    * @since 1.9.0
    */
-  record ExperimentalVariable(Long id, String name, Set<String> levels, @Nullable String unit) {
+  record ExperimentalVariable(String name, Set<String> levels, @Nullable String unit) {
+
+    public ExperimentalVariable(String name, Set<String> levels) {
+      this(name, levels, "");
+    }
 
     public ExperimentalVariable {
       levels = Set.copyOf(levels);
@@ -537,7 +552,7 @@ public List<ExperimentalVariable> experimentalVariables() {
    * @param experimentalVariables
    */
   record ExperimentalVariableDeletions(List<ExperimentalVariable> experimentalVariables) implements
-      ExperimentUpdateRequestBody {
+      ExperimentDeletionRequestBody {
 
     public ExperimentalVariableDeletions {
       experimentalVariables = List.copyOf(experimentalVariables);
@@ -556,7 +571,7 @@ public List<ExperimentalVariable> experimentalVariables() {
    * @since 1.9.0
    */
   record ExperimentalVariables(List<ExperimentalVariable> experimentalVariables) implements
-      ExperimentUpdateResponseBody {
+      ExperimentUpdateResponseBody, ExperimentDeletionResponseBody {
 
 
     public ExperimentalVariables {
@@ -1068,7 +1083,6 @@ record ProjectResponsibleDeletion() implements ProjectDeletionRequestBody {
    */
   record ProjectUpdateResponse(String projectId, ProjectUpdateResponseBody responseBody,
                                String requestId) {
-
     public ProjectUpdateResponse {
       if (projectId == null) {
         throw new IllegalArgumentException("Project ID cannot be null");
@@ -1078,7 +1092,6 @@ record ProjectUpdateResponse(String projectId, ProjectUpdateResponseBody respons
       }
       if (requestId == null || requestId.isBlank()) {
         requestId = UUID.randomUUID().toString();
-        ;
       }
     }
 
@@ -1095,6 +1108,50 @@ public Optional<String> retrieveRequestId() {
     boolean hasRequestId() {
       return nonNull(requestId);
     }
+
+  }
+
+  record ExperimentDeletionRequest(String projectId, String experimentId, String requestId,
+                                   ExperimentDeletionRequestBody body) {
+
+    public ExperimentDeletionRequest {
+      if (projectId == null) {
+        throw new IllegalArgumentException("Project ID cannot be null");
+      }
+      if (projectId.isBlank()) {
+        throw new IllegalArgumentException("Project ID cannot be blank");
+      }
+      if (experimentId == null || experimentId.isBlank()) {
+        throw new IllegalArgumentException("Experiment ID cannot be empty");
+      }
+      if (requestId == null || requestId.isBlank()) {
+        requestId = UUID.randomUUID().toString();
+      }
+    }
+
+    public ExperimentDeletionRequest(String projectId, String experimentId,
+        ExperimentDeletionRequestBody body) {
+      this(projectId, experimentId, null, body);
+    }
+  }
+
+  record ExperimentDeletionResponse(String projectId, String experimentId, String requestId,
+                                    ExperimentDeletionResponseBody body) {
+
+    public ExperimentDeletionResponse {
+      if (projectId == null) {
+        throw new IllegalArgumentException("Project ID cannot be null");
+      }
+      if (projectId.isBlank()) {
+        throw new IllegalArgumentException("Project ID cannot be blank");
+      }
+      if (experimentId == null || experimentId.isBlank()) {
+        throw new IllegalArgumentException("Experiment ID cannot be empty");
+      }
+      if (requestId == null || requestId.isBlank()) {
+        throw new IllegalArgumentException("Request information cannot be empty");
+      }
+    }
   }
 
   /**