Make parse method static

Co-authored-by: Sven F. <[email protected]>

Author: KochTobi

src/main/java/life/qbic/registration/openbis/OpenBisDropboxETL.java

@@ -36,14 +36,8 @@
 public class OpenBisDropboxETL extends AbstractJavaDataSetRegistrationDropboxV2 {
 
   private static final String PROVENANCE_FILE_NAME = "provenance.json";
-  private final ProvenanceParser provenanceParser;
 
-  public OpenBisDropboxETL() {
-    provenanceParser = new ProvenanceParser();
-  }
-
-  protected OpenBisDropboxETL(ProvenanceParser provenanceParser) {
-    this.provenanceParser = requireNonNull(provenanceParser, "provenanceParser must not be null");
+  public OpenBisDropboxETL(){
   }
 
 
@@ -58,7 +52,7 @@ public boolean shouldRetryProcessing(DataSetRegistrationContext context, Excepti
 
   @Override
   public void process(IDataSetRegistrationTransactionV2 transaction) {
-    DataSetProvenance dataSetProvenance = provenanceParser.parseProvenanceJson(
+    DataSetProvenance dataSetProvenance = ProvenanceParser.parseProvenanceJson(
         new File(transaction.getIncoming(), PROVENANCE_FILE_NAME));
 
     String measurementId = dataSetProvenance.measurementId();

src/main/java/life/qbic/registration/openbis/ProvenanceParser.java

@@ -14,7 +14,7 @@ public class ProvenanceParser {
   private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper();
   private static final Class<DataSetProvenance> DATA_SET_PROVENANCE_CLASS = DataSetProvenance.class;
 
-  DataSetProvenance parseProvenanceJson(File provenanceFile) {
+  static DataSetProvenance parseProvenanceJson(File provenanceFile) {
     try {
       return OBJECT_MAPPER.readValue(provenanceFile,
           DATA_SET_PROVENANCE_CLASS);

src/test/java/life/qbic/registration/openbis/ProvenanceParserTest.groovy

@@ -8,7 +8,7 @@ class ProvenanceParserTest extends Specification {
 
     def "parsing a valid file works"() {
         when:
-        var resultingProvenanceObject = new ProvenanceParser().parseProvenanceJson(validFile)
+        var resultingProvenanceObject = ProvenanceParser.parseProvenanceJson(validFile)
         then:
         resultingProvenanceObject.measurementId() == "NGSQTEST001AE-1234512312"
         and: