Skip to content

Commit 3fd432d

Browse files
committed
fix: correct reloading of table after committing changes; correct loading of properties in testing environment
1 parent 5ed760a commit 3fd432d

File tree

1 file changed

+24
-13
lines changed

1 file changed

+24
-13
lines changed

src/main/java/life/qbic/portal/portlet/UserDBPortletUI.java

Lines changed: 24 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import java.util.HashMap;
66
import java.util.List;
77
import java.util.Map;
8+
import java.util.Objects;
89
import java.util.Set;
910

1011
import org.apache.commons.lang3.StringUtils;
@@ -66,7 +67,7 @@ public class UserDBPortletUI extends QBiCPortletUI {
6667
private Map<String, Integer> affiMap;
6768
private Map<String, Integer> personMap;
6869
private Map<String, ProjectInfo> projectMap;
69-
70+
7071
private TabSheet options;
7172

7273
private ConfigurationManager manager;
@@ -86,9 +87,10 @@ protected Layout getPortletContent(final VaadinRequest request) {
8687

8788
String userID = "";
8889
boolean success = true;
90+
manager = ConfigurationManagerFactory.getInstance();
91+
8992
if (PortalUtils.isLiferayPortlet()) {
9093
// read in the configuration file
91-
manager = ConfigurationManagerFactory.getInstance();
9294

9395
logger.info("User DB portlet is running on Liferay and user is logged in.");
9496
userID = PortalUtils.getUser().getScreenName();
@@ -107,6 +109,7 @@ protected Layout getPortletContent(final VaadinRequest request) {
107109
// establish connection to the OpenBIS API
108110
try {
109111
logger.debug("trying to connect to openbis");
112+
110113
this.openbis = new OpenBisClient(manager.getDataSourceUser(), manager.getDataSourcePassword(),
111114
manager.getDataSourceUrl());
112115
this.openbis.login();
@@ -129,7 +132,7 @@ protected Layout getPortletContent(final VaadinRequest request) {
129132
dbControl = new DBManager(config);
130133

131134
initTabs();
132-
135+
133136
layout.addComponent(options);
134137
return layout;
135138
}
@@ -214,12 +217,18 @@ private void initTabs() {
214217

215218
Map<String, ProjectInfo> allProjects = dbControl.getProjectMap();
216219
for (Project p : openbisProjects) {
220+
String desc = Objects.toString(p.getDescription(), "");
221+
desc = desc.replace("\n", ";");
217222
String projectID = p.getIdentifier();
218223
String code = p.getCode();
219224
if (allProjects.get(projectID) == null)
220-
userProjects.put(projectID, new ProjectInfo(p.getSpaceCode(), code, "", "", -1));
221-
else
222-
userProjects.put(projectID, allProjects.get(projectID));
225+
userProjects.put(projectID, new ProjectInfo(p.getSpaceCode(), code, desc, "", -1));
226+
else {
227+
ProjectInfo info = allProjects.get(projectID);
228+
info.setDescription(desc);
229+
userProjects.put(projectID, info);
230+
}
231+
223232
}
224233

225234
projectMap = new HashMap<>();
@@ -360,17 +369,19 @@ public void valueChange(ValueChangeEvent event) {
360369
collaborators.add(c);
361370
}
362371
projects.setCollaboratorsOfProject(collaborators);
363-
}
364-
365-
Person investigator = getPersonOrNull(projectMap.get(item).getInvestigator());
366-
Person manager = getPersonOrNull(projectMap.get(item).getManager());
367-
Person contact = getPersonOrNull(projectMap.get(item).getContact());
368372

369-
projects.handleProjectValueChange(item, investigator, contact, manager);
373+
Person investigator = getPersonOrNull(projectMap.get(item).getInvestigator());
374+
Person manager = getPersonOrNull(projectMap.get(item).getManager());
375+
Person contact = getPersonOrNull(projectMap.get(item).getContact());
376+
377+
projects.handleProjectValueChange(item, investigator, contact, manager);
378+
} else {
379+
projects.handleProjectDeselect();
380+
}
370381
}
371382

372383
private Person getPersonOrNull(String name) {
373-
if(personMap.get(name)!=null) {
384+
if (personMap.get(name) != null) {
374385
return dbControl.getPersonWithAffiliations(personMap.get(name)).get(0);
375386
}
376387
return null;

0 commit comments

Comments
 (0)