Skip to content

Commit 98b4b6b

Browse files
authored
Merge pull request #20 from qbicsoftware/hotfix/mysql-connector
Hotfix/mysql connector
2 parents 6727bfd + b516d2f commit 98b4b6b

File tree

5 files changed

+37
-29
lines changed

5 files changed

+37
-29
lines changed

.travis.yml

+3
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,9 @@ branches:
1818
only:
1919
- master
2020
- development
21+
- /^release\/.*$/
22+
- /^hotfix\/.*$/
23+
- /^[vV]?\d+\.\d+\.\d+$/ # matches e.g., v1.2.3, 1.2.3, V1.2.3
2124

2225
# added to make logs look cleaner, crisper, certified fresh
2326
before_install: unset _JAVA_OPTIONS

pom.xml

+12-8
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,17 @@
66
<parent>
77
<groupId>life.qbic</groupId>
88
<artifactId>portlet-parent-pom</artifactId>
9-
<version>1.4.0</version>
9+
<version>3.1.0</version>
1010
</parent>
1111
<artifactId>user-db-portlet</artifactId>
12-
<version>1.8.0</version>
12+
<version>1.8.1</version>
1313
<name>User Database Portlet</name>
1414
<url>http://github.com/qbicsoftware/user-db-portlet</url>
1515
<packaging>war</packaging>
16+
<properties>
17+
<vaadin.version>7.7.8</vaadin.version>
18+
<vaadin.plugin.version>7.7.8</vaadin.plugin.version>
19+
</properties>
1620
<!-- we only need to tell maven where to find our parent pom and other QBiC
1721
dependencies -->
1822
<repositories>
@@ -27,7 +31,7 @@
2731
</snapshots>
2832
<id>nexus-snapshots</id>
2933
<name>QBiC Snapshots</name>
30-
<url>https://qbic-repo.am10.uni-tuebingen.de/repository/maven-snapshots</url>
34+
<url>http://qbic-repo.qbic.uni-tuebingen.de:8081/repository/maven-snapshots</url>
3135
</repository>
3236
<repository>
3337
<releases>
@@ -40,7 +44,7 @@
4044
</snapshots>
4145
<id>nexus-releases</id>
4246
<name>QBiC Releases</name>
43-
<url>https://qbic-repo.am10.uni-tuebingen.de/repository/maven-releases</url>
47+
<url>http://qbic-repo.qbic.uni-tuebingen.de:8081/repository/maven-releases</url>
4448
</repository>
4549
</repositories>
4650
<!-- To avoid inconsistencies across projects, plase check which librares
@@ -52,22 +56,22 @@
5256
<dependency>
5357
<groupId>life.qbic</groupId>
5458
<artifactId>portal-utils-lib</artifactId>
55-
<version>1.6.0</version>
59+
<version>2.2.1</version>
5660
</dependency>
5761
<dependency>
5862
<groupId>life.qbic</groupId>
5963
<artifactId>core-utils-lib</artifactId>
60-
<version>1.2.1</version>
64+
<version>1.7.0</version>
6165
</dependency>
6266
<dependency>
6367
<groupId>life.qbic</groupId>
6468
<artifactId>openbis-client-lib</artifactId>
65-
<version>1.1.4</version>
69+
<version>1.4.0</version>
6670
</dependency>
6771
<dependency>
6872
<groupId>life.qbic</groupId>
6973
<artifactId>data-model-lib</artifactId>
70-
<version>1.3.0</version>
74+
<version>1.11.0</version>
7175
</dependency>
7276
<dependency>
7377
<groupId>org.mariadb.jdbc</groupId>

src/main/java/life/qbic/portal/portlet/UserDBPortletUI.java

+22-17
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import java.util.ArrayList;
55
import java.util.Arrays;
66
import java.util.HashMap;
7+
import java.util.HashSet;
78
import java.util.List;
89
import java.util.Map;
910
import java.util.Objects;
@@ -26,10 +27,10 @@
2627
import com.vaadin.ui.Layout;
2728
import com.vaadin.ui.TabSheet;
2829
import com.vaadin.ui.VerticalLayout;
30+
import ch.ethz.sis.openbis.generic.asapi.v3.dto.experiment.Experiment;
31+
import ch.ethz.sis.openbis.generic.asapi.v3.dto.project.Project;
2932
import com.vaadin.ui.Button.ClickEvent;
3033
import com.vaadin.ui.Button.ClickListener;
31-
import ch.systemsx.cisd.openbis.generic.shared.api.v1.dto.Experiment;
32-
import ch.systemsx.cisd.openbis.generic.shared.api.v1.dto.Project;
3334
import life.qbic.datamodel.persons.Affiliation;
3435
import life.qbic.datamodel.persons.CollaboratorWithResponsibility;
3536
import life.qbic.datamodel.persons.Person;
@@ -213,19 +214,25 @@ private void initTabs() {
213214
}
214215
Map<String, ProjectInfo> userProjects = new HashMap<String, ProjectInfo>();
215216

216-
List<Project> openbisProjects = new ArrayList<Project>();
217+
List<Project> openbisProjectsForUser = new ArrayList<Project>();
218+
Set<String> spaces = new HashSet<>(openbis.getUserSpaces(userID));
217219

218-
openbisProjects = openbis.getOpenbisInfoService()
219-
.listProjectsOnBehalfOfUser(openbis.getSessionToken(), userID);
220+
List<Project> allOpenbisProjects = openbis.listProjects();
221+
for (Project p : allOpenbisProjects) {
222+
String space = p.getSpace().getCode();
223+
if (spaces.contains(space)) {
224+
openbisProjectsForUser.add(p);
225+
}
226+
}
220227

221228
Map<String, ProjectInfo> dbProjects = dbControl.getProjectMap();
222-
for (Project p : openbisProjects) {
229+
for (Project p : openbisProjectsForUser) {
223230
String desc = Objects.toString(p.getDescription(), "");
224231
desc = desc.replaceAll("\n+", ". ");
225-
String projectID = p.getIdentifier();
232+
String projectID = p.getIdentifier().getIdentifier();
226233
String code = p.getCode();
227234
if (dbProjects.get(projectID) == null)
228-
userProjects.put(projectID, new ProjectInfo(p.getSpaceCode(), code, desc, "", -1));
235+
userProjects.put(projectID, new ProjectInfo(p.getSpace().getCode(), code, desc, "", -1));
229236
else {
230237
ProjectInfo info = dbProjects.get(projectID);
231238
info.setDescription(desc);
@@ -253,8 +260,7 @@ private Map<String, Integer> fillMaxInputLengthMap() {
253260
res.putAll(dbControl.getColsMaxLengthsForTable("persons"));
254261
res.putAll(dbControl.getColsMaxLengthsForTable("organizations"));
255262
} catch (SQLException e) {
256-
// TODO Auto-generated catch block
257-
e.printStackTrace();
263+
logger.error(e.toString());
258264
}
259265
return res;
260266
}
@@ -271,8 +277,8 @@ private boolean canUsePortlet() {
271277
}
272278
}
273279
} catch (Exception e) {
274-
e.printStackTrace();
275280
logger.error("Could not fetch user groups. User won't be able to use portlet.");
281+
logger.error(e.toString());
276282
}
277283
return false;
278284
}
@@ -292,8 +298,8 @@ private boolean isAdmin() {
292298
}
293299
}
294300
} catch (Exception e) {
295-
e.printStackTrace();
296301
logger.error("Could not fetch user groups. User won't be able to use portlet.");
302+
logger.error(e.toString());
297303
}
298304
return false;
299305
}
@@ -361,9 +367,9 @@ public void valueChange(ValueChangeEvent event) {
361367
dbControl.getCollaboratorsOfProject(project);
362368
// get openbis experiments and type
363369
Map<String, String> existingExps = new HashMap<String, String>();
364-
for (Experiment e : openbis.getExperimentsForProject2(project)) {
365-
String type = expTypeCodeTranslation.get(e.getExperimentTypeCode());
366-
String id = e.getIdentifier();
370+
for (Experiment e : openbis.getExperimentsOfProjectByCode(project)) {
371+
String type = expTypeCodeTranslation.get(e.getType().getCode());
372+
String id = e.getIdentifier().getIdentifier();
367373
if (type != null)
368374
existingExps.put(id, type);
369375
}
@@ -613,8 +619,7 @@ private void successfulCommit() {
613619
try {
614620
Thread.sleep(1000);
615621
} catch (InterruptedException e) {
616-
// TODO Auto-generated catch block
617-
e.printStackTrace();
622+
logger.error(e.toString());
618623
}
619624
initTabs();
620625
}

src/main/java/life/qbic/userdb/views/PersonInput.java

-3
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717

1818
import java.util.List;
1919
import java.util.Map;
20-
import java.util.Set;
2120
import com.vaadin.data.Property.ValueChangeEvent;
2221
import com.vaadin.data.Property.ValueChangeListener;
2322
import com.vaadin.data.Validator;
@@ -33,11 +32,9 @@
3332
import com.vaadin.ui.HorizontalLayout;
3433
import com.vaadin.ui.TextField;
3534
import com.vaadin.ui.themes.ValoTheme;
36-
import ch.systemsx.cisd.common.collection.RegExValidator;
3735
import life.qbic.datamodel.persons.Affiliation;
3836
import life.qbic.datamodel.persons.Person;
3937
import life.qbic.portal.Styles;
40-
import life.qbic.userdb.helpers.EmailFreeValidator;
4138
import life.qbic.userdb.helpers.RegExHelper;
4239

4340
public class PersonInput extends HorizontalLayout {

src/main/java/life/qbic/userdb/views/ProjectView.java

-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141
import com.vaadin.ui.TextField;
4242
import com.vaadin.ui.VerticalLayout;
4343
import com.vaadin.ui.themes.ValoTheme;
44-
import ch.systemsx.cisd.common.concurrent.TimerUtilities;
4544
import life.qbic.datamodel.identifiers.SampleCodeFunctions;
4645
import life.qbic.datamodel.persons.Affiliation;
4746
import life.qbic.datamodel.persons.CollaboratorWithResponsibility;

0 commit comments

Comments
 (0)