Skip to content

Commit 1b67fb9

Browse files
committed
make license, description and size in gb mandatory in model description
1 parent a3f08ae commit 1b67fb9

File tree

1 file changed

+3
-17
lines changed

1 file changed

+3
-17
lines changed

fastembed/common/model_description.py

+3-17
Original file line numberDiff line numberDiff line change
@@ -19,24 +19,11 @@ class BaseModelDescription:
1919
model: str
2020
sources: ModelSource
2121
model_file: str
22-
description: str = ""
23-
license: str = ""
24-
size_in_GB: Optional[float] = None
22+
description: str
23+
license: str
24+
size_in_GB: float
2525
additional_files: list[str] = field(default_factory=list)
2626

27-
def validate_info(self) -> None:
28-
if self.license == "":
29-
raise ValueError("license is required in builtin model description")
30-
31-
if self.description == "":
32-
raise ValueError("description is required in builtin model description")
33-
34-
if self.size_in_GB is None:
35-
raise ValueError("size_in_GB is required in builtin model description")
36-
37-
def __post_init__(self) -> None:
38-
self.validate_info()
39-
4027

4128
@dataclass(frozen=True)
4229
class DenseModelDescription(BaseModelDescription):
@@ -45,7 +32,6 @@ class DenseModelDescription(BaseModelDescription):
4532

4633
def __post_init__(self) -> None:
4734
assert self.dim is not None, "dim is required for dense model description"
48-
self.validate_info()
4935

5036

5137
@dataclass(frozen=True)

0 commit comments

Comments
 (0)