Skip to content

Commit cbf516e

Browse files
qiniu-ciqiniu-ci
andauthored
实现 Issue #318: Issue创建的对应container命令有问题 (#319)
* Initial plan for Issue #318: Issue创建的对应container命令有问题 * fix: remove timestamp from Issue container names Remove timestamp suffix from Issue container and config directory names to match PR naming format and maintain one-Issue-one-container principle. Before: provider__org__repo__issue__number__timestamp After: provider__org__repo__issue__number This ensures container names remain consistent across program restarts and prevents creation of duplicate containers for the same Issue. Closes #318 * fix: remove timestamp from Issue container names Remove timestamp suffix from Issue container and config directory names to match PR naming format and maintain one-Issue-one-container principle. Before: provider__org__repo__issue__number__timestamp After: provider__org__repo__issue__number This ensures container names remain consistent across program restarts and prevents creation of duplicate containers for the same Issue. Closes #318 --------- Co-authored-by: qiniu-ci <[email protected]>
1 parent ba68bf3 commit cbf516e

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

internal/code/utils.go

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -189,9 +189,8 @@ func generateContainerName(provider, org, repoName string, workspace *models.Wor
189189
// For PRs: provider__org__repo__pr__number
190190
return fmt.Sprintf("%s__%s__%s__pr__%d", provider, org, repoName, workspace.PRNumber)
191191
} else if workspace.Issue != nil {
192-
// For Issues: provider__org__repo__issue__number__timestamp
193-
timestamp := workspace.CreatedAt.Unix()
194-
return fmt.Sprintf("%s__%s__%s__issue__%d__%d", provider, org, repoName, workspace.Issue.GetNumber(), timestamp)
192+
// For Issues: provider__org__repo__issue__number
193+
return fmt.Sprintf("%s__%s__%s__issue__%d", provider, org, repoName, workspace.Issue.GetNumber())
195194
} else {
196195
// Fallback: use timestamp for uniqueness
197196
timestamp := workspace.CreatedAt.Unix()
@@ -205,9 +204,8 @@ func generateConfigDirName(provider, org, repoName string, workspace *models.Wor
205204
// For PRs: .provider-org-repo-pr-number
206205
return fmt.Sprintf(".%s-%s-%s-pr-%d", provider, org, repoName, workspace.PRNumber)
207206
} else if workspace.Issue != nil {
208-
// For Issues: .provider-org-repo-issue-number-timestamp
209-
timestamp := workspace.CreatedAt.Unix()
210-
return fmt.Sprintf(".%s-%s-%s-issue-%d-%d", provider, org, repoName, workspace.Issue.GetNumber(), timestamp)
207+
// For Issues: .provider-org-repo-issue-number
208+
return fmt.Sprintf(".%s-%s-%s-issue-%d", provider, org, repoName, workspace.Issue.GetNumber())
211209
} else {
212210
// Fallback: use timestamp for uniqueness
213211
timestamp := workspace.CreatedAt.Unix()

0 commit comments

Comments
 (0)