Skip to content

orderly-set 5.4.0 breaks deepdiff on Python 3.8 #539

@mallman-experian

Description

@mallman-experian

Describe the bug

When we run our unit tests using deepdiff 8.4.2, it brings in orderly-set 5.4.0 and we see failure stack traces like

.venv/lib/python3.8/site-packages/deepdiff/__init__.py:10: in <module>
    from .diff import DeepDiff as DeepDiff
.venv/lib/python3.8/site-packages/deepdiff/diff.py:21: in <module>
    from deepdiff.helper import (strings, bytes_type, numbers, uuids, ListItemRemovedOrAdded, notpresent,
.venv/lib/python3.8/site-packages/deepdiff/helper.py:16: in <module>
    from orderly_set import StableSetEq as SetOrderedBase  # median: 1.0867 s for cache test, 5.63s for all tests
.venv/lib/python3.8/site-packages/orderly_set/__init__.py:1: in <module>
    from orderly_set.sets import OrderedSet, StableSet, StableSetEq, OrderlySet, SortedSet  # NOQA
.venv/lib/python3.8/site-packages/orderly_set/sets.py:50: in <module>
    class StableSet(MutableSet[T], Sequence[T]):
.venv/lib/python3.8/site-packages/orderly_set/sets.py:380: in StableSet
    def indexes(self, keys: list[Hashable]) -> list[int]:
E   TypeError: 'type' object is not subscriptable

This problem did not occur with the previous version of orderly-set, 5.3.2.

To Reproduce
Install and import deepdiff 8.4.2 using a fresh env (to get orderly-set 5.4.0).

Expected behavior

It doesn't break.

OS, DeepDiff version and Python version (please complete the following information):

  • OS: Ubuntu
  • Version ???
  • Python Version 3.8.18
  • DeepDiff Version 8.4.2

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions