From 75095ad8f9d2571dd31061c7c03f05589490d7f6 Mon Sep 17 00:00:00 2001 From: ENCALADA Date: Thu, 4 Jun 2020 21:44:22 +0200 Subject: [PATCH] Add missing changes in the generated buildRun CRD - Add missing spec.output declaration in the buildrun. I think this was missing in https://github.com/redhat-developer/build/pull/233 - Add missing timeout in spec.status.buildSpec, I think this was missed somehow after https://github.com/redhat-developer/build/pull/158 was merged. Also, this can be reproduced by doing `operator-sdk generate crds` --- deploy/crds/build.dev_buildruns_crd.yaml | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/deploy/crds/build.dev_buildruns_crd.yaml b/deploy/crds/build.dev_buildruns_crd.yaml index 68be480516..cb4b66bb61 100644 --- a/deploy/crds/build.dev_buildruns_crd.yaml +++ b/deploy/crds/build.dev_buildruns_crd.yaml @@ -63,6 +63,26 @@ spec: required: - name type: object + output: + description: Output refers to the location where the generated image + would be pushed to. It will overwrite the output image in build spec + properties: + credentials: + description: SecretRef is a reference to the Secret containing the + credentials to push the image to the registry + properties: + name: + description: 'Name of the referent. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names + TODO: Add other useful fields. apiVersion, kind, uid?' + type: string + type: object + image: + description: ImageURL is the URL where the image will be pushed + to. + type: string + required: + - image + type: object resources: description: 'Compute Resources required by the build container which can overwrite the configuration in Build. More info: https://kubernetes.io/docs/concepts/configuration/manage-compute-resources-container/' @@ -262,6 +282,9 @@ spec: required: - name type: object + timeout: + description: Timeout defines the maximum run time of a build run. + type: string required: - output - source