Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenWebUI issues #1261

Closed
geoand opened this issue Feb 3, 2025 · 9 comments
Closed

OpenWebUI issues #1261

geoand opened this issue Feb 3, 2025 · 9 comments
Assignees

Comments

@geoand
Copy link
Collaborator

geoand commented Feb 3, 2025

When using the OpenWebUI for Quarkud LangChain4j workshop one sees the following:

2025-02-03 10:50:23,186 ERROR [[io.qua.dev](http://io.qua.dev/).run.jso.JsonRpcCodec] (executor-thread-18) Error in JsonRPC Call: java.lang.IllegalArgumentException: text cannot be null or blank
        at dev.langchain4j.internal.Exceptions.illegalArgument(Exceptions.java:19)
        at dev.langchain4j.internal.ValidationUtils.ensureNotBlank(ValidationUtils.java:98)
        at dev.langchain4j.data.segment.TextSegment.<init>(TextSegment.java:29)
        at dev.langchain4j.data.segment.TextSegment.from(TextSegment.java:94)
        at dev.langchain4j.model.embedding.EmbeddingModel.embed(EmbeddingModel.java:24)
        at dev.langchain4j.model.embedding.onnx.bgesmallenq.BgeSmallEnQuantizedEmbeddingModel_ORSMi1NXux1KZo2401CGXcECI8s_Synthetic_ClientProxy.embed(Unknown Source)
        at io.quarkiverse.langchain4j.runtime.devui.EmbeddingStoreJsonRPCService.findRelevant(EmbeddingStoreJsonRPCService.java:102)
        at io.quarkiverse.langchain4j.runtime.devui.EmbeddingStoreJsonRPCService_ClientProxy.findRelevant(Unknown Source)
        at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
        at java.base/java.lang.reflect.Method.invoke(Method.java:580)
        at io.quarkus.devui.runtime.comms.JsonRpcRouter.lambda$invoke$12(JsonRpcRouter.java:323)
        at io.smallrye.mutiny.unchecked.UncheckedSupplier.lambda$toSupplier$0(UncheckedSupplier.java:41)
        at io.smallrye.context.impl.wrappers.SlowContextualSupplier.get(SlowContextualSupplier.java:21)
        at io.smallrye.mutiny.operators.uni.builders.UniCreateFromItemSupplier.subscribe(UniCreateFromItemSupplier.java:28)
        at io.smallrye.mutiny.operators.AbstractUni.subscribe(AbstractUni.java:36)
        at io.smallrye.mutiny.operators.uni.UniRunSubscribeOn.lambda$subscribe$0(UniRunSubscribeOn.java:27)
        at io.quarkus.vertx.core.runtime.VertxCoreRecorder$15.runWith(VertxCoreRecorder.java:637)
        at org.jboss.threads.EnhancedQueueExecutor$Task.doRunWith(EnhancedQueueExecutor.java:2675)
        at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2654)
        at org.jboss.threads.EnhancedQueueExecutor.runThreadBody(EnhancedQueueExecutor.java:1627)
        at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1594)
        at org.jboss.threads.DelegatingRunnable.run(DelegatingRunnable.java:11)
        at org.jboss.threads.ThreadLocalResettingRunnable.run(ThreadLocalResettingRunnable.java:11)
        at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
        at java.base/java.lang.Thread.run(Thread.java:1583)

cc @iocanel @phillip-kruger

@phillip-kruger
Copy link
Member

I guess you need to handle if text is null here:

@jmartisk jmartisk self-assigned this Feb 4, 2025
@jmartisk
Copy link
Collaborator

jmartisk commented Feb 4, 2025

You mean Dev UI, right? This happens when you search for relevant embeddings but provide a blank reference text. Right, this could be handled on the client side so that it fails faster, no need to send a request to the server in this case

@geoand
Copy link
Collaborator Author

geoand commented Feb 4, 2025

Right, DevUI

@jmartisk
Copy link
Collaborator

jmartisk commented Feb 4, 2025

Btw. I'm noticing that we're probably splitting the documents into too small segments, max-segment-size=100 seems to split it into chunks shorter even than one sentence

@geoand
Copy link
Collaborator Author

geoand commented Feb 4, 2025

Right, DevUI I mean the OpenWebUI that can be opened from the DevUI

@jmartisk
Copy link
Collaborator

jmartisk commented Feb 4, 2025

OpenWebUI isn't integrated with the EmbeddingStoreJsonRPCService in any way, so this has to be from the Embedding store page in the Dev UI

@geoand
Copy link
Collaborator Author

geoand commented Feb 4, 2025

Might have copy and pasted the wrong stack trace

@jmartisk
Copy link
Collaborator

jmartisk commented Feb 4, 2025

Anyway, I've submitted #1265 to fix the Dev UI thing, if you have any more, please provide more context :)

but I don't think the OpenWebUI makes any sense in step 6 because it just calls the OpenAI model directly and you can't get RAG working with it AFAIK

@geoand
Copy link
Collaborator Author

geoand commented Feb 11, 2025

Can't really remember more at this point, so let's close the issue

@geoand geoand closed this as not planned Won't fix, can't repro, duplicate, stale Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants