Merge pull request #15 from felipinas/fix/ignore-chain-in-update-coll…

…ection-method Fix: ignore chain in update collection method
quavedev · Dec 3, 2024 · 8bab265 · 8bab265
2 parents 41fb151 + dd9799b
commit 8bab265
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/rules/no-sync-mongo-methods-on-server.js b/lib/rules/no-sync-mongo-methods-on-server.js
@@ -134,7 +134,8 @@ module.exports = {
                 return;
               }
             }
-            if(node.object.type === 'MemberExpression'){
+            // this means it's a call chain like crypto.createHmac().update()
+            if(['MemberExpression', 'CallExpression'].includes(node.object.type) && node.type === 'MemberExpression'){
               // we can ignore longer than 1 call chain
               debug(
                 `Skipping ${invalidFunction} to be considered error because it was used in a longer than 1 call chain`,

diff --git a/tests/lib/rules/no-sync-mongo-methods-on-server.js b/tests/lib/rules/no-sync-mongo-methods-on-server.js
@@ -48,6 +48,13 @@ ruleTester.run('no-sync-mongo-methods-on-server', rule, {
       modules.fetch();
       `,
     },
+    {
+      code: `
+      crypto
+        .createHmac('sha256', secretIntercomKey)
+        .update(userId);
+      `,
+    },
   ],
 
   invalid: [