With this commit we solve the jsdom setup issue causing problems in github actions. Even though configurable: true is set, redefining navigator on window or global can fail in environments where it's already non-configurable, which seems to be the case in GitHub Actions.

jurra · jurra · commit e0baf5d9a9cd · 2025-07-02T09:59:11.000+02:00
diff --git a/tests/setup/jsdomSetup.js b/tests/setup/jsdomSetup.js
@@ -39,20 +39,30 @@ import { JSDOM } from 'jsdom';
  */
 export function setupJsdom() {
     const { window } = new JSDOM('<!doctype html><html><body></body></html>');
+
     global.window = window;
     global.document = window.document;
 
-    // Modify the existing navigator object instead of overwriting it
-    Object.defineProperty(window, 'navigator', {
-        value: { userAgent: 'node.js' },
-        writable: false,
-        configurable: true,
-    });
+    // Patch the userAgent safely, even if it's readonly
+    if (!window.navigator.userAgent || window.navigator.userAgent !== 'node.js') {
+        try {
+            Object.defineProperty(window.navigator, 'userAgent', {
+                value: 'node.js',
+                configurable: true,
+            });
+        } catch (e) {
+            // Fallback if it fails due to being non-configurable
+            console.warn('Failed to override navigator.userAgent:', e.message);
+        }
+    }
 
-    // Optionally attach window.navigator to global
-    Object.defineProperty(global, 'navigator', {
-        get() {
-            return window.navigator;
-        },
-    });
+    // Bind window.navigator to global (as a getter, readonly)
+    if (!('navigator' in global)) {
+        Object.defineProperty(global, 'navigator', {
+            get() {
+                return window.navigator;
+            },
+            configurable: true,
+        });
+    }
 }
