Merge pull request #683 from shota3506/avoid-unkeyed-fields-usage-in-generated-code

ackleymi · web-flow · commit 9d46c6445600 · 2025-01-22T22:30:56.000-06:00
Avoid unkeyed fields usage for exported struct in generated code
diff --git a/cmd/generate-fix/internal/templates.go b/cmd/generate-fix/internal/templates.go
@@ -282,9 +282,9 @@ type {{ .Name }} struct {
 // FromMessage creates a {{ .Name }} from a quickfix.Message instance.
 func FromMessage(m *quickfix.Message) {{ .Name }} {
 	return {{ .Name }}{
-		Header: {{ .TransportPackage}}.Header{&m.Header},
+		Header: {{ .TransportPackage}}.Header{Header: &m.Header},
 		Body: &m.Body,
-		Trailer: {{ .TransportPackage}}.Trailer{&m.Trailer},
+		Trailer: {{ .TransportPackage}}.Trailer{Trailer: &m.Trailer},
 		Message: m,
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -282,9 +282,9 @@ type {{ .Name }} struct {`
`282`	`282`	`// FromMessage creates a {{ .Name }} from a quickfix.Message instance.`
`283`	`283`	`func FromMessage(m *quickfix.Message) {{ .Name }} {`
`284`	`284`	`return {{ .Name }}{`
`285`		`- Header: {{ .TransportPackage}}.Header{&m.Header},`
	`285`	`+ Header: {{ .TransportPackage}}.Header{Header: &m.Header},`
`286`	`286`	`Body: &m.Body,`
`287`		`- Trailer: {{ .TransportPackage}}.Trailer{&m.Trailer},`
	`287`	`+ Trailer: {{ .TransportPackage}}.Trailer{Trailer: &m.Trailer},`
`288`	`288`	`Message: m,`
`289`	`289`	`}`
`290`	`290`	`}`