Skip to content

Commit 0b9b6a4

Browse files
committed
Issue #12: there's a breakingchange on quickwit, this parameter is throwing a 400 error
1 parent d9853f4 commit 0b9b6a4

File tree

3 files changed

+1
-4
lines changed

3 files changed

+1
-4
lines changed

pkg/quickwit/client/client.go

-1
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,6 @@ func (c *baseClientImpl) createMultiSearchRequests(searchRequests []*SearchReque
190190
for _, searchReq := range searchRequests {
191191
mr := multiRequest{
192192
header: map[string]interface{}{
193-
"search_type": "query_then_fetch",
194193
"ignore_unavailable": true,
195194
"index": c.index,
196195
},

pkg/quickwit/client/client_test.go

-1
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,6 @@ func TestClient_ExecuteMultisearch(t *testing.T) {
9595

9696
assert.Equal(t, "my-index", jHeader.Get("index").MustString())
9797
assert.True(t, jHeader.Get("ignore_unavailable").MustBool(false))
98-
assert.Equal(t, "query_then_fetch", jHeader.Get("search_type").MustString())
9998
assert.Empty(t, jHeader.Get("max_concurrent_shard_requests"))
10099
assert.False(t, jHeader.Get("ignore_throttled").MustBool())
101100

pkg/quickwit/snapshot_test.go

+1-2
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,7 @@ package quickwit
8282
// queryHeader := []byte(`
8383
// {
8484
// "ignore_unavailable": true,
85-
// "index": ["testdb-2022.11.14"],
86-
// "search_type": "query_then_fetch"
85+
// "index": ["testdb-2022.11.14"]
8786
// }
8887
// `)
8988

0 commit comments

Comments
 (0)